gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 38330: (QA follow-up) Remove use of metadata_extractor 

We had a local method for getting opac_suppressed in Koha::Biblio which
relied on extracting from the MARC record.  Now that we have an
opac_suppressed field in the Biblio table, we no longer need this
wrapper method.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Martin Renvoize 2025-03-14 16:09:08 +00:00 committed by Lucas Gass
parent 2fdf0d12d0
commit de3f1abae8
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
3 changed files with 1 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Koha/Biblio.pm
View File

@ -1687,20 +1687,6 @@ sub normalized_upc {
return $self->metadata_extractor->get_normalized_upc;
}
=head3 opac_suppressed
my $opac_suppressed = $biblio->opac_suppressed();
Returns whether the record is flagged as suppressed in the OPAC.
FIXME: Revisit after 38330 discussion
=cut
sub opac_suppressed {
my ($self) = @_;
return $self->metadata_extractor->get_opac_suppression();
}
=head3 normalized_oclc
my $normalized_oclc = $biblio->normalized_oclc

17
Koha/Biblio/Metadata/Extractor/MARC.pm
View File

@ -100,23 +100,6 @@ sub get_control_number {
return $control_number;
}
=head2 get_opac_suppression
my $opac_suppressed = $extractor->get_opac_suppression();
Returns whether the record is flagged as suppressed in the OPAC.
FIXME: Revisit after 38330 discussion
=cut
sub get_opac_suppression {
my ($self) = @_;
my $record = $self->metadata;
return $record->subfield( '942', 'n' ) ? 1 : 0;
}
=head3 _normalize_string
my $normalized_string = $self->_normalize_string($string);

25
t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC.t
View File

@ -20,7 +20,7 @@
use Modern::Perl;
use Test::NoWarnings;
use Test::More tests => 3;
use Test::More tests => 2;
use Test::Exception;
use t::lib::TestBuilder;
@ -55,26 +55,3 @@ subtest 'get_control_number() tests' => sub {
is( $extractor->get_control_number, $identifier, 'Returns the right value' );
}
};
subtest 'get_opac_suppression() tests' => sub {
plan tests => 8;
foreach my $marcflavour (qw( MARC21 UNIMARC )) {
t::lib::Mocks::mock_preference( 'marcflavour', $marcflavour );
my $record = MARC::Record->new();
my $extractor = Koha::Biblio::Metadata::Extractor->new( { metadata => $record } );
is( $extractor->get_opac_suppression(), 0, 'If 942$n absent, then not suppressed' );
$record->append_fields( MARC::Field->new( '942', q{}, q{}, n => '' ) );
is( $extractor->get_opac_suppression(), 0, 'If 942$n has empty string, then not suppressed' );
$record->field('942')->replace_with( MARC::Field->new( '942', q{}, q{}, n => 'potato' ) );
is( $extractor->get_opac_suppression(), 1, 'If 942$n has something different than false, then suppressed' );
$record->field('942')->replace_with( MARC::Field->new( '942', q{}, q{}, n => '1' ) );
is( $extractor->get_opac_suppression(), 1, 'If 942$n is 1, then suppressed' );
}
};