Bug 23057: (QA follow-up) Remove new AddReturn message ReturnOfLostItemBlocked, use existing pattern from returns.pl

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Matha Fuerst <mfuerst@hmcpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 80cbb81224)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Kyle M Hall 2019-06-11 07:46:57 -04:00 committed by Fridolin Somers
parent 78c11c51c0
commit dd7d23d67b
2 changed files with 3 additions and 4 deletions

View File

@ -1945,7 +1945,6 @@ sub AddReturn {
}
if ( $item->itemlost and C4::Context->preference("BlockReturnOfLostItems") ) {
$messages->{'ReturnOfLostItemBlocked'};
$doreturn = 0;
}

View File

@ -89,8 +89,8 @@ sub do_checkin {
if ($messages->{withdrawn}) {
$self->alert_type('99');
}
if ($messages->{ReturnOfLostItemBlocked}) {
$self->alert_type('99');
if ($messages->{WasLost}) {
$self->alert_type('99') if C4::Context->preference("BlockReturnOfLostItems");
}
if ($messages->{Wrongbranch}) {
$self->{item}->destination_loc($messages->{Wrongbranch}->{Rightbranch});
@ -128,7 +128,7 @@ sub do_checkin {
$self->{item}->hold_patron_id( $messages->{ResFound}->{borrowernumber} );
$self->{item}->destination_loc( $messages->{ResFound}->{branchcode} );
}
# ignoring messages: NotIssued, WasLost, WasTransfered
# ignoring messages: NotIssued, WasTransfered
if ($cv_triggers_alert) {
$self->alert( defined $self->alert_type ); # Overwrites existing alert value, should set to 0 if there is no alert type