Bug 26438: Rename temporary Koha::Item variables to avoid conflict

Returns from Koha::Item calls were stored in temporary variables
called $item. Unfortunately they occur in routines already with
an $item variable holding a lineitem and hide that variable although
only required for two lines of code. An error occurs if girfield
is called on the wrong variable. Renamed all three occurences
of $item to $kitem to avoid the error

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 647e05d826)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Colin Campbell 2020-09-11 18:16:28 +01:00 committed by Lucas Gass
parent 276602aadb
commit dc94e57b96
1 changed files with 6 additions and 6 deletions

View File

@ -720,8 +720,8 @@ sub quote_item {
while ( $created < $order_quantity ) {
$item_hash->{biblionumber} = $bib->{biblionumber};
$item_hash->{biblioitemnumber} = $bib->{biblioitemnumber};
my $item = Koha::Item->new( $item_hash )->store;
my $itemnumber = $item->itemnumber;
my $kitem = Koha::Item->new( $item_hash )->store;
my $itemnumber = $kitem->itemnumber;
$logger->trace("Added item:$itemnumber");
$schema->resultset('AqordersItem')->create(
{
@ -812,8 +812,8 @@ sub quote_item {
$item_hash->{biblionumber} = $bib->{biblionumber};
$item_hash->{biblioitemnumber} = $bib->{biblioitemnumber};
my $item = Koha::Item->new( $item_hash )->store;
my $itemnumber = $item->itemnumber;
my $kitem = Koha::Item->new( $item_hash )->store;
my $itemnumber = $kitem->itemnumber;
$logger->trace("New item $itemnumber added");
$schema->resultset('AqordersItem')->create(
{
@ -882,8 +882,8 @@ sub quote_item {
};
$new_item->{biblionumber} = $bib->{biblionumber};
$new_item->{biblioitemnumber} = $bib->{biblioitemnumber};
my $item = Koha::Item->new( $new_item )->store;
my $itemnumber = $item->itemnumber;
my $kitem = Koha::Item->new( $new_item )->store;
my $itemnumber = $kitem->itemnumber;
$logger->trace("New item $itemnumber added");
$schema->resultset('AqordersItem')->create(
{