Bug 39947: Do not use bg-* Bootstrap classes

This patch removes a few instances of the "bg-*" class from our
templates, and adds some CSS to ensure that we can safely add the
".bg-*-subtle" class to a div with ".page-section."

To test, apply the patch and rebuild the staff interface CSS.

- Go to Administration -> Circulation and fine rules. The information
  about rules specificity should have a pale blue background matching
  the color found in an "info" style alert.
- Go to Tools -> Import patrons. The "Notes" section should match what
  you saw in the previous step.
  NOTE: I made a small change to whitespace in the markup of this
  section to prevent the database column list from displaying without
  line breaks--an issue introduced by the global tidy.
- Go to Authorities and perform a search which will return results.
  - Click Actions -> Merge on one of the results. An "info" style alert
    should be shown at the top of the page, "Merging with authority..."
  - Without completing a merge, go to the Authorities home page. You
    should see an identical alert.
- In KTD, bibliographic record 369 can be used to test errors related to
  encoding problems:
  - Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369
    and confirm that you see a "warning" style alert (a pale yellow
    background).
  - Edit that record and confirm you see a similar error messages on
    that page.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 753ce067e6)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
(cherry picked from commit 71f601dabb)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss

@@ -10,7 +10,7 @@ $nav-menu-bullet: url( "data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/
     margin-bottom: 1rem;
     padding: 1rem;
 
-    &:not( .bg-danger, .bg-warning, .bg-info, .bg-success, .bg-primary, .action ) {
+    &:not( .bg-danger, .bg-warning, .bg-info, .bg-success, .bg-primary, .bg-danger-subtle, .bg-warning-subtle, .bg-info-subtle, .bg-success-subtle, .bg-primary-subtle, .action ) {
         background-color: #FFF;
     }
 }

koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt

@@ -53,7 +53,7 @@
                     [% END %]
                 </h1>
 
-                <div class="page-section bg-info">
+                <div class="page-section bg-info-subtle">
                     <p>The rules are applied from most specific to less specific, using the first found in this order:</p>
                     <ul>
                         <li>same library, same patron category, same item type</li>

koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities-home.tt

@@ -33,7 +33,7 @@
 
             <h1>Authorities</h1>
 
-            <div id="merge_in_progress" class="page-section bg-info" style="display:none;"></div>
+            <div id="merge_in_progress" class="alert alert-info" style="display:none;"></div>
 
             [%- SET StaffAuthoritiesHome = AdditionalContents.get( location => "StaffAuthoritiesHome", lang => lang, library => Branches.GetLoggedInBranchcode ) -%]
             [%- FOREACH block IN StaffAuthoritiesHome.content -%]

koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt

@@ -47,7 +47,7 @@
     [% INCLUDE 'authorities-toolbar.inc' %]
 <h1>Authority search results</h1>
 
-<div id="merge_in_progress" class="page-section bg-info" style="display:none;"></div>
+<div id="merge_in_progress" class="alert alert-info" style="display:none;"></div>
 <div class="page-section">
     [% IF ( query_error ) %]
         <div class="alert alert-warning"><p><strong>Error:</strong> [% query_error | html %]</p></div>

koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt

@@ -104,7 +104,7 @@
                         <div id="catalogue_detail_biblio" class="col">
 
                         [% IF decoding_error || analytics_error %]
-                            <div class="page-section bg-danger">
+                            <div class="alert alert-warning">
                                 <h1>Errors found</h1>
                                 [% IF decoding_error %]
                                     <h2>Encoding errors</h2>

koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt

@@ -824,7 +824,7 @@ $(document).ready(function(){
             <div class="col-md-10 offset-md-1">
                 [% INCLUDE 'messages.inc' %]
                 [% IF ( INVALID_METADATA ) %]
-                    <div class="page-section bg-danger">
+                    <div class="alert alert-warning">
                         <h1>Errors found</h1>
                         <p><strong>This record had encoding issues, non-xml characters have been stripped in order to allow editing. Please be cautious when saving that some data may have been removed from the record.</strong></p>
                         <pre class="problem">[% INVALID_METADATA | html %]</pre>

koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt

@@ -396,7 +396,7 @@
 </div>
 
 <div class="col-sm-6">
-    <div class="page-section bg-info">
+    <div class="page-section bg-info-subtle">
         <h2>Notes:</h2>
         <ul>
             <li>The first line in the file must be a header row defining which columns you are supplying in the import file.</li>