gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 18736: Unit tests for GetBudgetHierarchy 

prove -v t/db_dependent/Budgets.t

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Nick Clemens 2018-08-24 11:11:19 +00:00
parent 4ccbae8879
commit d9b3d0fa36
1 changed files with 28 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
t/db_dependent/Budgets.t
View File

@ -1,6 +1,6 @@
#!/usr/bin/perl
use Modern::Perl;
use Test::More tests => 146;
use Test::More tests => 147;
BEGIN {
use_ok('C4::Budgets')
@ -969,7 +969,7 @@ subtest 'GetBudgetSpent and GetBudgetOrdered' => sub {
subtest 'GetBudgetSpent GetBudgetOrdered GetBudgetsPlanCell tests' => sub {
plan tests => 16;
plan tests => 24;
#Let's build an order, we need a couple things though
t::lib::Mocks::mock_preference('OrderPriceRounding','nearest_cent');
@ -987,8 +987,13 @@ subtest 'GetBudgetSpent GetBudgetOrdered GetBudgetsPlanCell tests' => sub {
authorised_value => 'PICKLE',
}
});
my $spent_budget_period = $builder->build({ source => 'Aqbudgetperiod', value => {
}
});
my $spent_budget = $builder->build({ source => 'Aqbudget', value => {
sort1_authcat => $budget_authcat->{category_name},
budget_period_id => $spent_budget_period->{budget_period_id},
budget_parent_id => undef,
}
});
my $spent_orderinfo = {
@ -1033,6 +1038,16 @@ subtest 'GetBudgetSpent GetBudgetOrdered GetBudgetsPlanCell tests' => sub {
$spent_ordered = GetBudgetOrdered( $spent_order->{budget_id} );
is($spent_ordered,'78.8',"We expect the ordered amount to be equal to the estimated price rounded times quantity");
#Test GetBudgetHierarchy for rounding
t::lib::Mocks::mock_preference('OrderPriceRounding','');
my $gbh = GetBudgetHierarchy($spent_budget->{budget_period_id});
is ( @$gbh[0]->{budget_spent}+0, 0, "We expect this to be an exact order cost * quantity");
is ( @$gbh[0]->{budget_ordered}+0, 78.8336, "We expect this to be an exact order cost * quantity");
t::lib::Mocks::mock_preference('OrderPriceRounding','nearest_cent');
$gbh = GetBudgetHierarchy($spent_budget->{budget_period_id});
is ( @$gbh[0]->{budget_spent}+0, 0, "We expect this to be an rounded order cost * quantity");
is ( @$gbh[0]->{budget_ordered}+0, 78.8, "We expect this to be an exact order cost * quantity");
#Let's test some budget planning
#Regression tests for bug 18736
#We need an item to test by BRANCHES
@ -1097,7 +1112,7 @@ subtest 'GetBudgetSpent GetBudgetOrdered GetBudgetsPlanCell tests' => sub {
});
my $received_order = $builder->build({ source => 'Aqorder', value => $spent_orderinfo });
#And receive
#And receive a copy of the order so we have both spent and ordered values
ModReceiveOrder({
biblionumber => $spent_order->{biblionumber},
@ -1118,6 +1133,16 @@ subtest 'GetBudgetSpent GetBudgetOrdered GetBudgetsPlanCell tests' => sub {
$spent_spent = GetBudgetSpent( $spent_order->{budget_id} );
is($spent_spent,'78.8',"We expect the spent amount to be equal to the estimated price rounded times quantity");
#Test GetBudgetHierarchy for rounding
t::lib::Mocks::mock_preference('OrderPriceRounding','');
$gbh = GetBudgetHierarchy($spent_budget->{budget_period_id});
is ( @$gbh[0]->{budget_spent}, 78.8336, "We expect this to be an exact order cost * quantity");
is ( @$gbh[0]->{budget_ordered}, 78.8336, "We expect this to be an exact order cost * quantity");
t::lib::Mocks::mock_preference('OrderPriceRounding','nearest_cent');
$gbh = GetBudgetHierarchy($spent_budget->{budget_period_id});
is ( @$gbh[0]->{budget_spent}+0, 78.8, "We expect this to be a rounded order cost * quantity");
is ( @$gbh[0]->{budget_ordered}, 78.8, "We expect this to be a rounded order cost * quantity");
};
sub _get_dependencies {