gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 16810: Fines note not showing on checkout 

Fines did not show on patron checkout and detail pages unless amout
was greater than syspref NoIssueCharges.

This patch fixes the logic in
koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc

Additionally, it changes links to buttons and makes some small
text changes to ease translation.

To test:
- Apply patch
- Display checkout or detail page and verify proper display for
   a patron who has
   - no fines (no message)
   - fines not exceeding syspref NoissueCharges (message)
   - fines exceeding syspref NoIssueCharges (message)

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit a353fe5d98)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
This commit is contained in:
Marc Véron 2016-07-04 14:30:24 +02:00 committed by Frédéric Demians
parent c27ba3c7bd
commit d8a12683dc
1 changed files with 6 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc
View File

@ -1,22 +1,13 @@
[% USE Price %]
[% SET NoIssuesCharge = Koha.Preference('noissuescharge') %]
[% IF NoIssuesCharge && fines > NoIssuesCharge %]
[% IF fines > 0 %]
<li>
<span class="circ-hlt">Fees &amp; Charges:</span>
Patron has <a href="/cgi-bin/koha/members/boraccount.pl?borrowernumber=[% borrowernumber %]">
Outstanding fees &amp; charges
[% IF ( fines ) %]
of [% fines | $Price %]
[% END %]
</a>.
[% IF !Koha.Preference('AllowFineOverride') %]
<span class="circ-hlt">Checkouts are BLOCKED because fine balance is OVER THE LIMIT.</span>
Patron has outstanding fees &amp; charges of [% fines | $Price %].
[% IF !Koha.Preference('AllowFineOverride') && NoIssuesCharge && fines > NoIssuesCharge %]
<span class="circ-hlt">Checkouts are BLOCKED because fine balance is OVER THE LIMIT.</span>
[% END %]
<a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% borrowernumber %]">Make payment</a>
or
<a href="/cgi-bin/koha/members/paycollect.pl?borrowernumber=[% borrowernumber %]">Pay all fines</a></li>
<a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% borrowernumber %]" class="btn btn-mini" >Make payment</a>
<a href="/cgi-bin/koha/members/paycollect.pl?borrowernumber=[% borrowernumber %]" class="btn btn-mini" >Pay all fines</a></li>
</li>
[% END %]