From d8452a72d9e09dccd4e3b25b5f6b894e0f4fa2b1 Mon Sep 17 00:00:00 2001
From: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Date: Mon, 15 Sep 2025 17:22:31 +0100
Subject: [PATCH] Bug 38201: Restore subscriptions and allow appendToShow to
 ignore panes where required

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../prog/js/vue/components/ResourceShow.vue            | 10 +++++++++-
 .../prog/js/vue/components/ShowElement.vue             |  7 ++++++-
 .../prog/js/vue/components/SplitScreenWrapper.vue      |  8 +++++++-
 .../prog/js/vue/components/Vendors/VendorResource.vue  |  3 ++-
 .../prog/js/vue/composables/base-resource.js           |  3 +++
 5 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ResourceShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ResourceShow.vue
index be8c7ab28b..eca040d522 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ResourceShow.vue
+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ResourceShow.vue
@@ -150,11 +150,19 @@ export default {
                     resource: resource.value,
                     additionalProps: additionalProps.value,
                 })
-                ?.filter(field => field.hidden(resource.value))
+                ?.filter(
+                    field =>
+                        !field.hidden ||
+                        (field.hidden && field.hidden(resource.value))
+                )
                 .map(field => {
                     return {
                         name: field.name,
                         fields: [field],
+                        ...(props.instancedResource.showGroupsDisplayMode ===
+                        "splitScreen"
+                            ? { splitPane: field.splitPane }
+                            : {}),
                     };
                 });
 
diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ShowElement.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ShowElement.vue
index 57b465ed02..4b28e55230 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ShowElement.vue
+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ShowElement.vue
@@ -111,7 +111,12 @@
         </template>
     </template>
     <template v-else-if="attribute?.type === 'component'">
-        <template v-if="attribute.hidden && attribute.hidden(resource)">
+        <template
+            v-if="
+                !attribute.hidden ||
+                (attribute.hidden && attribute.hidden(resource))
+            "
+        >
             <label v-if="attribute.label">{{ attribute.label }}:</label>
             <component
                 :is="requiredComponent"
diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/SplitScreenWrapper.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/SplitScreenWrapper.vue
index c916a7e445..8aeb592907 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/SplitScreenWrapper.vue
+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/SplitScreenWrapper.vue
@@ -1,5 +1,5 @@
 <template>
-    <div class="row">
+    <div class="row" style="margin-bottom: 0.9em">
         <div class="col-sm-6">
             <slot
                 name="splitPane"
@@ -13,6 +13,12 @@
             ></slot>
         </div>
     </div>
+    <template v-if="determineGroupsForPane(null).length > 0">
+        <slot
+            name="splitPane"
+            :paneFieldList="determineGroupsForPane(null)"
+        ></slot>
+    </template>
 </template>
 
 <script>
diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue
index 5dc50e1add..afe51b8c9a 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue
+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue
@@ -957,11 +957,11 @@ export default {
                             value: $__("contracts"),
                         },
                     },
+                    splitPane: null,
                 },
                 {
                     type: "component",
                     name: $__("Subscription details"),
-                    hidden: vendor => vendor.subscriptions_count,
                     componentPath:
                         "@koha-vue/components/Vendors/VendorSubscriptions.vue",
                     componentProps: {
@@ -969,6 +969,7 @@ export default {
                             type: "resource",
                         },
                     },
+                    splitPane: "right",
                 },
             ];
         };
diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/composables/base-resource.js b/koha-tmpl/intranet-tmpl/prog/js/vue/composables/base-resource.js
index 1caa533e7a..0d2bd82a69 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/vue/composables/base-resource.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/composables/base-resource.js
@@ -480,6 +480,9 @@ export function useBaseResource(resourceConfig) {
                     );
                 if (splitScreenGrouping) {
                     groupInfo.splitPane = splitScreenGrouping.pane;
+                } else {
+                    // Default to left
+                    groupInfo.splitPane = "left";
                 }
             }
             if (component === "Show" && resource) {