Bug 32060: Use selectrow_array

Trivial ergonomic patch, use selectrow_array, no need to prepare the
query

+ perltidy the sub

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Jonathan Druart 2023-05-16 16:36:26 +02:00 committed by Tomas Cohen Arazi
parent b6ae2c1ee3
commit d78bbbeddd
No known key found for this signature in database
GPG Key ID: 0A272EA1B2F3C15F
1 changed files with 8 additions and 8 deletions

View File

@ -1833,15 +1833,15 @@ sub UpsertMarcControlField {
sub GetFrameworkCode {
my ($biblionumber) = @_;
my $cache = Koha::Cache::Memory::Lite->get_instance();
my $cache_key = "FrameworkCode-$biblionumber";
my $frameworkcode = $cache->get_from_cache($cache_key);
unless (defined $frameworkcode) {
my $cache = Koha::Cache::Memory::Lite->get_instance();
my $cache_key = "FrameworkCode-$biblionumber";
my $frameworkcode = $cache->get_from_cache($cache_key);
unless ( defined $frameworkcode ) {
my $dbh = C4::Context->dbh;
my $sth = $dbh->prepare("SELECT frameworkcode FROM biblio WHERE biblionumber=?");
$sth->execute($biblionumber);
($frameworkcode) = $sth->fetchrow;
$cache->set_in_cache($cache_key, $frameworkcode);
($frameworkcode) = $dbh->selectrow_array(
"SELECT frameworkcode FROM biblio WHERE biblionumber=?",
undef, $biblionumber );
$cache->set_in_cache( $cache_key, $frameworkcode );
}
return $frameworkcode;
}