gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 33430: (follow-up) Prevent anonymous suggestions from breaking the table 

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Matt Blenkinsop 2025-05-19 08:39:59 +00:00 committed by Katrin Fischer
parent 8a4394130b
commit d669cab7a2
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
View File

@ -1375,11 +1375,14 @@
orderable: true,
render: function (data, type, row, meta) {
let suggester = row.suggester;
let node = '<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=%s">%s'.format(suggester.patron_id, suggester.surname);
if(suggester.firstname) node += ', %s'.format(suggester.firstname);
if(suggester.cardnumber) node += ' (%s)'.format(suggester.cardnumber);
node += '</a>';
return node;
if(suggester) {
let node = '<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=%s">%s'.format(suggester.patron_id, suggester.surname);
if(suggester.firstname) node += ', %s'.format(suggester.firstname);
if(suggester.cardnumber) node += ' (%s)'.format(suggester.cardnumber);
node += '</a>';
return node;
}
return ''
}
},
{
@ -1387,7 +1390,7 @@
searchable: false,
orderable: true,
render: function (data, type, row, meta) {
return escape_str(row.suggester.category.name);
return escape_str(row.suggester ? row.suggester.category.name : '');
},
},
{
@ -1411,7 +1414,7 @@
searchable: true,
orderable: true,
render: function (data, type, row, meta) {
if(row?.manager) {
if(row.manager) {
let node = '<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=%s">%s'.format(row.manager?.patron_id, row.manager?.surname);
if(row.manager?.firstname) node += ', %s'.format(row.manager?.firstname);
node += '</a>';