gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 24488: perf - move patrons_count out of the loop 

Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Jonathan Druart 2020-11-18 11:14:10 +01:00
parent 774d4e9ab4
commit d54e32fa3a
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
circ/pendingreserves.pl
View File

@ -209,6 +209,18 @@ foreach my $item ( @all_items ) {
push @{$all_items->{$item->biblionumber}}, $item;
}
# patrons count per biblio
my $patrons_count = {
map { $_->{biblionumber} => $_->{patrons_count} } @{ Koha::Holds->search(
{},
{
select => [ 'biblionumber', { count => { distinct => 'borrowernumber' } } ],
as => [qw( biblionumber patrons_count )],
group_by => [qw( biblionumber )]
},
)->unblessed
}
};
# make final reserves hash and fill with info
my $reserves;
@ -253,13 +265,9 @@ foreach my $bibnum ( @biblionumbers ){
$reserves->{$bibnum}->{items_count} = $items_count;
# patrons with holds
my $patrons_count = Koha::Holds->search(
{ biblionumber => $bibnum },
{ distinct => 1, columns => qw(me.borrowernumber) }
)->count;
$reserves->{$bibnum}->{patrons_count} = $patrons_count;
$hold_info->{patrons_count} = $patrons_count->{$bibnum};
my $pull_count = $items_count <= $patrons_count ? $items_count : $patrons_count;
my $pull_count = $items_count <= $patrons_count->{$bibnum} ? $items_count : $patrons_count->{$bibnum};
if ( $pull_count == 0 ) {
delete($reserves->{$bibnum});
next;