gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 17585: Replace ->get_account_lines with ->account 

And return a Koha::Account instead of a Koha::Account::Lines

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2016-12-06 07:58:34 +00:00 committed by Kyle M Hall
parent ce92367784
commit d4a15fc1f1
2 changed files with 9 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Koha/Patron.pm
View File

@ -548,16 +548,15 @@ sub get_age {
return $age;
}
=head3 get_account_lines
=head3 account
my $fines = $patron->get_account_lines
my $account = $patron->account
=cut
sub get_account_lines {
sub account {
my ($self) = @_;
my $account_lines = $self->_result->accountlines;
return Koha::Account::Lines->_new_from_dbic($account_lines);
return Koha::Account->new( { patron_id => $self->borrowernumber } );
}
=head3 type

22
t/db_dependent/Koha/Patrons.t
View File

@ -19,7 +19,7 @@
use Modern::Perl;
use Test::More tests => 17;
use Test::More tests => 18;
use Test::Warn;
use DateTime;
@ -501,26 +501,14 @@ subtest 'get_age' => sub {
$patron->delete;
};
subtest 'get_account_lines' => sub {
plan tests => 2;
subtest 'account' => sub {
plan tests => 1;
my $patron = $builder->build({source => 'Borrower'});
my $accountline_1 = $builder->build({ source => 'Accountline',
value => { borrowernumber => $patron->{borrowernumber},
amount => 42,
amountoutstanding => 42 }
});
my $accountline_2 = $builder->build({ source => 'Accountline',
value => { borrowernumber => $patron->{borrowernumber},
amount => -13,
amountoutstanding => -13 }
});
$patron = Koha::Patrons->find( $patron->{borrowernumber} );
my $account_lines = $patron->get_account_lines;
is( $account_lines->count, 2, 'There should have 2 account lines for that patron' );
is( ref($account_lines), 'Koha::Account::Lines', 'get_account_lines should return a Koha::Account::Lines object' );
my $account = $patron->account;
is( ref($account), 'Koha::Account', 'account should return a Koha::Account object' );
$patron->delete;
};