gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 30909: Retain permanent_location if mapped 

If items.permanent_location is mapped to a MARC subfields we must retain
the value, not using items.location

Test plan:
1 - Map permanent_location to a marc field
2 - Expose that field in the item editor
3 - Change the location of the item and retain the permanent location on saving
4 - note that permanent location has not changed

Test the different other situation, when adding and editing: Empty the field, change only location, change only permanent_location, etc.

Signed-off-by: andrew <andrewfh@dubcolib.org>

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit e2668a6857)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 346be764e7)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
This commit is contained in:
Jonathan Druart 2022-06-07 11:27:04 +02:00 committed by Arthur Suzuki
parent 369b1f724b
commit d15d61dcf4
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
cataloguing/additem.pl
View File

@ -177,8 +177,11 @@ if ($op eq "additem") {
my @v = grep { $_ ne "" }
uniq $input->multi_param( "items." . $c );
next if !@v
&& $c ne 'permanent_location'; # See 27837
next unless @v;
if ( $c eq 'permanent_location' ) { # See 27837
$item->make_column_dirty('permanent_location');
}
$item->$c(join ' | ', @v);
}
@ -442,6 +445,10 @@ if ($op eq "additem") {
my @v = map { ( defined $_ && $_ eq '' ) ? undef : $_ } $input->multi_param( "items." . $c );
next unless @v;
if ( $c eq 'permanent_location' ) { # See 27837
$item->make_column_dirty('permanent_location');
}
if ( scalar(@v) == 1 && not defined $v[0] ) {
delete $new_values->{$c};
} else {