Bug 18611: [QA Follow-up] Make SQL query more readable

Make it more explicit by adding join statements.

Test plan:
See next patch for adding a unit test.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Mason James <mtj@kohaaloha.com>
This commit is contained in:
Marcel de Rooy 2017-05-26 10:20:00 +02:00 committed by Mason James
parent 560115f9a6
commit d08e4c28a3
1 changed files with 6 additions and 1 deletions

View File

@ -1066,7 +1066,12 @@ sub GetImportBatchRangeDesc {
sub GetItemNumbersFromImportBatch {
my ($batch_id) = @_;
my $dbh = C4::Context->dbh;
my $sth = $dbh->prepare("SELECT items.itemnumber FROM import_batches,import_records,import_items, items WHERE import_batches.import_batch_id=import_records.import_batch_id AND import_records.import_record_id=import_items.import_record_id AND items.itemnumber=import_items.itemnumber AND import_batches.import_batch_id=?");
my $sql = q|
SELECT itemnumber FROM import_items
INNER JOIN items USING (itemnumber)
INNER JOIN import_records USING (import_record_id)
WHERE import_batch_id = ?|;
my $sth = $dbh->prepare( $sql );
$sth->execute($batch_id);
my @items ;
while ( my ($itm) = $sth->fetchrow_array ) {