Bug 34624: [23.05.x] Add "for" attribute to label in header search forms which lack it

This patch adds a "for" label to header search forms labels which lack
it.

To test, apply the patch and test the affected pages to confirm that
clicking the label corresponding to the active search form can be
clicked to move cursor focus to that input field.

As you activate each search form, the cursor focus will automatically be
moved to the input. Click outside of the field to remove the focus, and
then click the label to test that it is correctly tied to the field.

- Staff interface home page:
  - Checkout, Check in, Renew, Search patrons, and Search catalog.
- Acquisitions: Vendor search and orders search
- Acquisitions -> Vendor search -> Vendor -> Contracts: Contract search
- Acquisitions -> Vendor search -> Vendor -> Basket -> Add to basket ->
  From a suggestion: Search suggestions
- Authorities: Main heading ($a only), Main heading, All headings, and
  Entire record.
- Administration -> Budgets: Search funds
- Administration -> Cities & towns: City search
- Administration -> Currencies: Currencies search
- Administration -> Desks: Search desks
  * With UseCirculationDesks enabled
- Administration -> Patron categories: Search patron categories
- Administration -> System preferences: Search system preferences
- Administration -> Z39.50 servers -> Z39.50 server search
- Cataloging: Cataloging search
- E-resource management: Search agreements, Search licenses, Search
  packages, and Search titles
  * With ERMModule enabled
- Patrons -> Search patrons
- Serials: Search subscriptions
- Tools -> Notices & slips: Search notices
This commit is contained in:
Owen Leonard 2023-10-13 11:28:56 +00:00 committed by Fridolin Somers
parent 936a311609
commit d067c4ae50
20 changed files with 63 additions and 63 deletions

View File

@ -4,29 +4,29 @@
<div id="supplier_search" role="tabpanel" class="tab-pane active">
<form name="findsupplier" action="/cgi-bin/koha/acqui/booksellers.pl" method="post">
<div class="form-title">
<label class="control-label">Vendor search</label>
<label class="control-label" for="supplier">Vendor search</label>
</div>
<div class="form-content">
<input type="text" name="supplier" id="supplier" class="head-searchbox form-control" placeholder="Search vendors" />
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>
<div id="orders_search" role="tabpanel" class="tab-pane">
<form action="/cgi-bin/koha/acqui/histsearch.pl" method="post">
<div class="form-title">
<label class="control-label">Orders search</label>
<label class="control-label" for="order_title">Orders search</label>
</div>
<div class="form-content">
<input type="text" id="title" class="form-control" placeholder="Title" name="title" size="13" value="[% title | html %]" />
<input type="text" id="order_title" class="form-control" placeholder="Title" name="title" size="13" value="[% title | html %]" />
<input type="text" id="searchsupplier" class="form-control" placeholder="Vendor" name="name" size="13" value="[% name | html %]" />
<button type="button" class="form-extra-content-toggle"><i class="fa fa-sliders"></i></button>
<input type="hidden" id="do_search" name="do_search" value="do" />
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
<div class="form-extra-content">
<div>

View File

@ -81,7 +81,7 @@
<input type="hidden" name="excluding" value="" />
<div class="form-title">
<label class="control-label">Search main heading ($a only)</label>
<label class="control-label" for="value_mainentry">Search main heading ($a only)</label>
</div>
<div class="form-content">
@ -89,13 +89,13 @@
<button type="button" class="form-extra-content-toggle"><i class="fa fa-sliders"></i></button>
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
<span class="form-extra-content">
<div class="form-extra-content">
[% INCLUDE authtype %]
[% INCLUDE operator %]
[% INCLUDE orderby %]
</span>
</div>
</form>
</div>
@ -108,7 +108,7 @@
<input type="hidden" name="type" value="intranet" />
<div class="form-title">
<label class="control-label">Search main heading</label>
<label class="control-label" for="value_mainheading">Search main heading</label>
</div>
<div class="form-content">
@ -116,13 +116,13 @@
<button type="button" class="form-extra-content-toggle"><i class="fa fa-sliders"></i></button>
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
<span class="form-extra-content">
<div class="form-extra-content">
[% INCLUDE authtype %]
[% INCLUDE operator %]
[% INCLUDE orderby %]
</span>
</div>
</form>
</div>
@ -133,7 +133,7 @@
<input type="hidden" name="marclist" value="match" />
<div class="form-title">
<label class="control-label">Search all headings</label>
<label class="control-label" for="value_matchheading">Search all headings</label>
</div>
<div class="form-content">
@ -141,13 +141,13 @@
<button type="button" class="form-extra-content-toggle"><i class="fa fa-sliders"></i></button>
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
<span class="form-extra-content">
<div class="form-extra-content">
[% INCLUDE authtype %]
[% INCLUDE operator %]
[% INCLUDE orderby %]
</span>
</div>
</form>
</div>
@ -160,7 +160,7 @@
<input type="hidden" name="excluding" value="" />
<div class="form-title">
<label class="control-label">Search entire record</label>
<label class="control-label" for="value_anywhere">Search entire record</label>
</div>
<div class="form-content">
@ -168,13 +168,13 @@
<button type="button" class="form-extra-content-toggle"><i class="fa fa-sliders"></i></button>
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
<span class="form-extra-content">
<div class="form-extra-content">
[% INCLUDE authtype %]
[% INCLUDE operator %]
[% INCLUDE orderby %]
</span>
</div>
</form>
</div>

View File

@ -9,7 +9,7 @@
<input type="hidden" name="budget_period_id" value="[% budget_period_id | html %]" />
<div class="form-title">
<label class="control-label">Search funds</label>
<label class="control-label" for="filter_budgetname">Search funds</label>
</div>
<div class="form-content">
@ -18,7 +18,7 @@
<button type="button" class="form-extra-content-toggle"><i class="fa fa-sliders"></i></button>
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
<div class="form-extra-content">
<label for="filter_budgetbranch">Library</label>

View File

@ -8,14 +8,14 @@
<div id="addbooks_search" role="tabpanel" class="tab-pane active">
<form name="search" action="addbooks.pl">
<div class="form-title">
<label class="control-label">Cataloging search</label>
<label class="control-label" for="cat_search">Cataloging search</label>
</div>
<div class="form-content">
<input class="head-searchbox form-control" type="text" name="q" id="cat_search" placeholder="Search the catalog and the reservoir" size="40" />
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>

View File

@ -9,7 +9,7 @@
[% END %]
<form action="/cgi-bin/koha/catalogue/search.pl" method="get" id="cat-search-block">
<div class="form-title">
<label class="control-label">Search catalog</label>
<label class="control-label" for="search-form">Search catalog</label>
</div>
<div class="form-content">
@ -23,7 +23,7 @@
<button type="button" class="form-extra-content-toggle"><i class="fa fa-sliders"></i></button>
[% END %]
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
<div class="form-extra-content">
[% IF ( Koha.Preference('IntranetCatalogSearchPulldown') ) %]

View File

@ -7,13 +7,13 @@
[% END %]
<form method="post" action="/cgi-bin/koha/circ/returns.pl" autocomplete="off">
<div class="form-title">
<label class="control-label">Check in</label>
<label class="control-label" for="ret_barcode">Check in</label>
</div>
<div class="form-content">
<input name="barcode" id="ret_barcode" class="head-searchbox form-control" accesskey="r" type="text" placeholder="Scan a barcode to check in" size="40"/>
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>
<!-- /checkin-search-box.inc -->

View File

@ -5,14 +5,14 @@
<div id="city_search" role="tabpanel" class="tab-pane active">
<form action="[% script_name | html %]" method="post">
<div class="form-title">
<label class="control-label">Search cities</label>
<label class="control-label" for="city_name_filter">Search cities</label>
</div>
<div class="form-content">
<input class="head-searchbox form-control" type="text" name="city_name_filter" id="city_name_filter" value="[% city_name_filter | html %]" placeholder="City search" />
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>

View File

@ -5,14 +5,14 @@
<div id="contract_description_search" role="tabpanel" class="tab-pane active">
<form action="[% script_name | html %]" method="post">
<div class="form-title">
<label class="control-label">Search contracts</label>
<label class="control-label" for="searchfield">Search contracts</label>
</div>
<div class="form-content">
<input class="head-searchbox form-control" type="text" name="searchfield" id="searchfield" value="[% searchfield | html %]" placeholder="Search by contract name or/and description:" size="40"/>
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>

View File

@ -5,14 +5,14 @@
<div id="currency_search" role="tabpanel" class="tab-pane active">
<form action="[% script_name | html %]" method="post">
<div class="form-title">
<label class="control-label">Search currencies</label>
<label class="control-label" for="description">Search currencies</label>
</div>
<div class="form-content">
<input class="head-searchbox form-control" type="text" name="description" id="description" value="[% searchfield | html %]" placeholder="Currencies search" />
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>

View File

@ -5,14 +5,14 @@
<div id="desk_search" role="tabpanel" class="tab-pane active">
<form action="[% script_name|html %]" method="post">
<div class="form-title">
<label class="control-label">Search desks</label>
<label class="control-label" for="desk_name">Search desks</label>
</div>
<div class="form-content">
<input class="head-searchbox form-control" type="text" name="desk_name" placeholder="Search desks" id="desk_name" value="[% searchfield|html %]" size="40" />
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>

View File

@ -5,48 +5,48 @@
<div id="agreement_search" role="tabpanel" class="tab-pane active">
<form action="/cgi-bin/koha/erm/agreements" method="get">
<div class="form-title">
<label class="control-label">Agreement search</label>
<label class="control-label" for="agreement_filter">Agreement search</label>
</div>
<div class="form-content">
<input type="text" name="q" id="agreement_filter" class="head-searchbox form-control" placeholder="Enter search keywords" size="40" />
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>
<div id="license_search" role="tabpanel" class="tab-pane">
<form action="/cgi-bin/koha/erm/licenses" method="get">
<div class="form-title">
<label class="control-label">License search</label>
<label class="control-label" for="license_filter">License search</label>
</div>
<div class="form-content">
<input type="text" name="q" id="license_filter" class="head-searchbox form-control" placeholder="Enter search keywords" size="40" />
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>
<div id="package_search" role="tabpanel" class="tab-pane">
<form action="/cgi-bin/koha/erm/eholdings/local/packages" method="get">
<div class="form-title">
<label class="control-label">Package search</label>
<label class="control-label" for="package_name_filter">Package search</label>
</div>
<div class="form-content">
<input type="text" name="package_name" id="package_name_filter" class="head-searchbox form-control" placeholder="Enter search keywords" size="40" />
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>
<div id="title_search" role="tabpanel" class="tab-pane">
<form action="/cgi-bin/koha/erm/eholdings/local/titles" method="get">
<div class="form-title">
<label class="control-label">Title search</label>
<label class="control-label" for="title_filter">Title search</label>
</div>
<div class="form-content">
<input type="text" name="publication_title" id="title_filter" class="head-searchbox form-control" placeholder="Enter search keywords" size="40" />
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>
</div><!-- /.tab-content -->

View File

@ -5,14 +5,14 @@
<div id="notices_search" role="tabpanel" class="tab-pane active">
<form action="/cgi-bin/koha/tools/letter.pl" method="post">
<div class="form-title">
<label class="control-label">Search notices</label>
<label class="control-label" for="searchfield">Search notices</label>
</div>
<div class="form-content">
<input class="head-searchbox form-control" type="text" name="searchfield" id="searchfield" value="" placeholder="Search existing notices"/>
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>

View File

@ -14,7 +14,7 @@
<input type="hidden" name="quicksearch" value="1" />
<div class="form-title">
<label class="control-label">Search patrons</label>
<label class="control-label" for="searchmember">Search patrons</label>
</div>
<div class="form-content">
@ -27,7 +27,7 @@
<button type="button" class="form-extra-content-toggle"><i class="fa fa-sliders"></i></button>
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
<div class="form-extra-content">
<div>

View File

@ -19,7 +19,7 @@
[% END %]
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>
<!-- /patron-search-box.inc -->

View File

@ -5,14 +5,14 @@
<div id="patron_category_search" role="tabpanel" class="tab-pane active">
<form action="[% script_name | html %]" method="post">
<div class="form-title">
<label class="control-label">Search patron categories</label>
<label class="control-label" for="category_search">Search patron categories</label>
</div>
<div class="form-content">
<input class="head-searchbox form-control" type="text" name="description" value="[% searchfield | html %]" placeholder="Search by patron category name" />
<input class="head-searchbox form-control" type="text" name="description" id="category_search" value="[% searchfield | html %]" placeholder="Search by patron category name" />
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>

View File

@ -7,14 +7,14 @@
<input type="hidden" name="op" value="search" />
<div class="form-title">
<label class="control-label">Search system preferences</label>
<label class="control-label" for="searchfield">Search system preferences</label>
</div>
<div class="form-content">
<input class="head-searchbox form-control" type="text" name="searchfield" id="searchfield" value="" placeholder="System preference search">
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>

View File

@ -7,13 +7,13 @@
[% END %]
<form method="post" action="/cgi-bin/koha/circ/renew.pl" autocomplete="off">
<div class="form-title">
<label class="control-label">Renew</label>
<label class="control-label" for="ren_barcode">Renew</label>
</div>
<div class="form-content">
<input name="barcode" id="ren_barcode" class="head-searchbox form-control" accesskey="r" type="text" placeholder="Scan a barcode to renew" size="40"/>
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>
<!-- /renew-search-box.inc -->

View File

@ -10,7 +10,7 @@
<input type="hidden" name="searched" value="1" />
<div class="form-title">
<label class="control-label">Search subscriptions</label>
<label class="control-label" for="ISSN_filter">Search subscriptions</label>
</div>
<div class="form-content">
@ -25,7 +25,7 @@
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
<div class="form-extra-content">
<div>
<label for="callnumber_filter">Call number:</label>

View File

@ -8,7 +8,7 @@
<input type="hidden" name="booksellerid" value="[% booksellerid | html %]" />
<div class="form-title">
<label class="control-label">Search suggestions</label>
<label class="control-label" for="searchtitle">Search suggestions</label>
</div>
<div class="form-content">
@ -17,7 +17,7 @@
<input type="text" class="head-searchbox form-control" placeholder="Publisher" id="searchpublishercode" name="publishercode" size="10" value="[% publishercode | html %]" />
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>

View File

@ -5,14 +5,14 @@
<div id="z3950_search" role="tabpanel" class="tab-pane active">
<form action="/cgi-bin/koha/admin/z3950servers.pl" method="post">
<div class="form-title">
<label class="control-label">Search Z39.50/SRU servers</label>
<label class="control-label" for="searchfield">Search Z39.50/SRU servers</label>
</div>
<div class="form-content">
<input class="head-searchbox form-control" type="text" name="searchfield" id="searchfield" value="[% searchfield | html %]" placeholder="Z39.50/SRU server search" />
</div>
<button type="submit"><i class="fa fa-arrow-right"></i></button>
<button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button>
</form>
</div>