gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 41444: (QA follow-up) Rearrange comments 

It would be at least helpful to add a reference to get_transfer here,
since we are replacing it here.
Used the opportunity to update the older comments

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 7f8f5cbb5c)
Signed-off-by: Jacob O'Mara <Jacob.omara@openfifth.co.uk>
This commit is contained in:
Marcel de Rooy 2026-02-27 09:32:23 +01:00 committed by Jacob O'Mara
parent d77f6baf9f
commit cdacd29741
No known key found for this signature in database
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
C4/Search.pm
View File

@ -1957,6 +1957,7 @@ sub searchResults {
# is item a waiting recall?
my $recallstatus = '';
# Check some statuses before checking transfer info, respect MaxSearchResultsItemsPerRecordStatusCheck
unless (
$item->{withdrawn}
|| $item->{itemlost}
@ -1967,18 +1968,8 @@ sub searchResults {
)
{
# A couple heuristics to limit how many times
# we query the database for item transfer information, sacrificing
# accuracy in some cases for speed;
#
# 1. don't query if item has one of the other statuses
# 2. don't check transit status if the bib has
# more than 20 items
#
# FIXME: to avoid having the query the database like this, and to make
# the in transit status count as unavailable for search limiting,
# should map transit status to record indexed in Zebra.
# NOTE: We are bypassing an expected Koha::Item->get_transfer call here for speed.
# TODO: Could we index the transfer status ?
my $transfer = Koha::Item::Transfers->search(
{ itemnumber => $item->{itemnumber}, datearrived => undef, datecancelled => undef },
{ order_by => [ { '-desc' => 'datesent' }, { '-asc' => 'daterequested' } ] }