Bug 33766: Fix ambiguous "Login" field
This patch introduces a new syspref 'OPACLoginLabelTextContent' which can be set
to the following values
- Cardnumber
- Username
- Cardnumber or Username
To test:
- Check that the label for
- The masthead inc
- The opac-auth template
- The opac-main template
- The opac-password-recovery template
- The opac-registration-confirmation template
- The opac-reset-password template
- The sco-main template
reflect the changes you made to the syspref
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Paul Derscheid
Katrin Fischer
parent
eef67f1e48
commit
cd58b70b76
|
|
@ -0,0 +1,18 @@
|
|||
use Modern::Perl;
|
||||
|
||||
return {
|
||||
bug_number => "33766",
|
||||
description => "Add syspref to determine text content of userid input field's label.",
|
||||
up => sub {
|
||||
my ($args) = @_;
|
||||
my ( $dbh, $out ) = @$args{qw(dbh out)};
|
||||
|
||||
# Do you stuffs here
|
||||
$dbh->do(
|
||||
q{INSERT IGNORE INTO systempreferences (variable,value) VALUES ('OPACLoginLabelTextContent','Cardnumber') }
|
||||
);
|
||||
|
||||
# sysprefs
|
||||
say $out "Added new system preference 'OPACLoginLabelTextContent'";
|
||||
},
|
||||
};
|
||||
|
|
@ -513,6 +513,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
|
|||
('OPACLocalCoverImages','0','1','Display local cover images on OPAC search and details pages.','YesNo'),
|
||||
('OpacLocationBranchToDisplay','holding','holding|home|both','In the OPAC, under location show which branch for Location in the record details.','Choice'),
|
||||
('OpacLocationOnDetail','holding','holding|home|both|column','In the OPAC detail, display the shelving location on its own column or under a library columns.', 'Choice'),
|
||||
('OPACLoginLabelTextContent','Cardnumber',NULL,NULL,NULL),
|
||||
('OpacMaintenance','0','','If ON, enables maintenance warning in OPAC','YesNo'),
|
||||
('OPACMandatoryHoldDates', '', '|start|end|both', 'Define which hold dates are required on OPAC reserve form', 'Choice'),
|
||||
('OpacMaxItemsToDisplay','50','','Max items to display at the OPAC on a biblio detail','Integer'),
|
||||
|
|
|
|||
|
|
@ -181,6 +181,15 @@ OPAC:
|
|||
column: "on a separate column"
|
||||
- "for items on the OPAC record details page."
|
||||
- "<br />Note: If 'on a separate column' is selected, you still need to enable the item_shelving_location display on the <a href='/cgi-bin/koha/admin/columns_settings.pl'>configure columns</a> administration page."
|
||||
-
|
||||
- Use
|
||||
- pref: OPACLoginLabelTextContent
|
||||
default: Cardnumber
|
||||
choices:
|
||||
Cardnumber: Cardnumber
|
||||
Username: Username
|
||||
"Cardnumber or Username": Cardnumber or Username
|
||||
- "as the text content of the userid input field's label."
|
||||
-
|
||||
- pref: OPACShowMusicalInscripts
|
||||
default: 0
|
||||
|
|
@ -533,6 +542,7 @@ OPAC:
|
|||
type: textarea
|
||||
syntax: text/html
|
||||
class: code
|
||||
|
||||
-
|
||||
- pref: OpacBrowseSearch
|
||||
default: 0
|
||||
|
|
|
|||
|
|
@ -438,7 +438,7 @@
|
|||
<input type="hidden" name="koha_login_context" value="opac" />
|
||||
<fieldset class="brief">
|
||||
<div class="local-login">
|
||||
<label for="muserid">Login:</label><input type="text" id="muserid" name="login_userid" autocomplete="off" />
|
||||
<label for="muserid">[% Koha.Preference('OPACLoginLabelTextContent') | html %]:</label><input type="text" id="muserid" name="login_userid" autocomplete="off" />
|
||||
<label for="mpassword">Password:</label><input type="password" id="mpassword" name="login_password" autocomplete="off" />
|
||||
<fieldset class="action">
|
||||
<input type="hidden" name="op" value="cud-login" />
|
||||
|
|
|
|||
|
|
@ -242,7 +242,7 @@
|
|||
<input type="hidden" name="[% INPUT.name | html %]" value="[% INPUT.value | html %]" />
|
||||
[% END %]
|
||||
<div class="form-group">
|
||||
<label for="userid">Login:</label>
|
||||
<label for="userid">[% Koha.Preference('OPACLoginLabelTextContent') | html %]:</label>
|
||||
<input class="form-control" type="text" size="25" id="userid" name="login_userid" autocomplete="off" />
|
||||
</div>
|
||||
<div class="form-group">
|
||||
|
|
|
|||
|
|
@ -200,7 +200,7 @@
|
|||
<p>If you do not have an external account, but do have a local account, you can still log in: </p>
|
||||
[% END # /IF identity_providers.size %]
|
||||
<div class="local-login">
|
||||
<label for="userid">Login:</label>
|
||||
<label for="userid">[% Koha.Preference('OPACLoginLabelTextContent') | html %]:</label>
|
||||
<input class="form-control" type="text" id="userid" name="login_userid" autocomplete="off" />
|
||||
<label for="password">Password:</label>
|
||||
<input class="form-control" type="password" id="password" name="login_password" autocomplete="off" />
|
||||
|
|
|
|||
|
|
@ -132,7 +132,7 @@
|
|||
<p>To reset your password, enter your login or your email address.</p>
|
||||
<fieldset class="brief">
|
||||
<div class="form-group">
|
||||
<label for="username">Login:</label>
|
||||
<label for="username">[% Koha.Preference('OPACLoginLabelTextContent') | html %]:</label>
|
||||
<input class="form-control" type="text" id="username" size="40" name="username" value="[% username | html %]" />
|
||||
</div>
|
||||
|
||||
|
|
|
|||
|
|
@ -109,7 +109,7 @@
|
|||
<input type="hidden" name="op" value="cud-login">
|
||||
<fieldset class="brief">
|
||||
<legend>Log in to your account:</legend>
|
||||
<label for="userid">Login:</label>
|
||||
<label for="userid">[% Koha.Preference('OPACLoginLabelTextContent') | html %]:</label>
|
||||
[% IF Koha.Preference('PatronSelfRegistrationPrefillForm') %]
|
||||
<input class="form-control" type="text" id="userid" size="10" name="login_userid" value="[% borrower.userid | html %]" autocomplete="off" />
|
||||
[% ELSE %]
|
||||
|
|
|
|||
|
|
@ -75,7 +75,7 @@
|
|||
|
||||
<fieldset class="brief">
|
||||
<div class="form-group">
|
||||
<label for="userid">Login:</label>
|
||||
<label for="userid">[% Koha.Preference('OPACLoginLabelTextContent') | html %]:</label>
|
||||
<input class="form-control" autocomplete="off" type="text" size="25" id="userid" name="userid" />
|
||||
</div>
|
||||
<div class="form-group">
|
||||
|
|
|
|||
|
|
@ -466,7 +466,7 @@
|
|||
<fieldset>
|
||||
[% IF ( Koha.Preference('SelfCheckoutByLogin') ) %]
|
||||
<legend>Log in to your account</legend>
|
||||
<label for="patronlogin">Login:</label>
|
||||
<label for="patronlogin">[% Koha.Preference('OPACLoginLabelTextContent') | html %]:</label>
|
||||
<input type="text" id="patronlogin" class="focus noEnterSubmit" size="20" name="patronlogin" autocomplete="off"/>
|
||||
<label for="patronpw">Password:</label>
|
||||
<input type="password" id="patronpw" size="20" name="patronpw" autocomplete="off"/>
|
||||
|
|
|
|||
Loading…
Reference in New Issue