Bug 20968: (follow-up) Respond to feedback

This patch:

- Removes the unecessary testing for
intranet_catalog_biblio_enhancements method in detail.pl
- Renames get_toolbar_button to get_intranet_catalog_toolbar_button

Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 7910a530b8)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

catalogue/detail.pl

@@ -66,11 +66,10 @@ my ( $template, $borrowernumber, $cookie, $flags ) = get_template_and_user(
 # Determine if we should be offering any enhancement plugin buttons
 if ( C4::Context->preference('UseKohaPlugins') &&
 	 C4::Context->config('enable_plugins') ) {
-	my @plugins = Koha::Plugins->new()->GetPlugins({
-		method => 'intranet_catalog_biblio_enhancements'
-	});
 	# Only pass plugins that can offer a toolbar button
-	@plugins = grep { $_->get_toolbar_button } @plugins;
+	my @plugins = Koha::Plugins->new()->GetPlugins({
+		method => 'get_intranet_catalog_toolbar_button'
+	});
 	$template->param(
 		plugins => \@plugins
 	);

koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc

@@ -140,7 +140,7 @@ CAN_user_serials_create_subscription ) %]
 [% END %]
 
 [% FOREACH p IN plugins %]
-	[% p.get_toolbar_button %]
+	[% p.get_intranet_catalog_toolbar_button %]
 [% END %]
 
 </div>