gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 38305: Can't delete or archive suggestions 

This patch corrects JS on the suggestions page so that the delete,
archive, and unarchive controls work.

The patch also modifies the markup of the "Delete" button so that it is
consisten with other pages.

To test, apply the patch and go to the suggestions page in the staff
interface.

- Log in to the staff interface as a user with "suggestions_manage"
  permission.
- If necessary, create a few suggestions to test with.
- From the table of suggestions, click the secondary menu on the "Edit"
  button for one of the suggestions.
  - Choose "Delete." You should get a confirmation dialog. Both the "OK"
    and "Cancel" options should work as expected.
  - Choose "Archive." There won't be a confirmation, and the title
    should disappear from the list.
    - To test whether the suggestion was archived, search for it using
      the sidebar form, checking the "Include archived" checkbox. The
      suggestion should show up in the list with an "Archived" label.
    - Clicking the "Edit" secondary menu on the archived suggestion
      should trigger a menu with an "Unarchive" option. Click that
      and confirm that the suggestion is no longer archived.
- Now log in as a user with only "suggestions_delete" permission but not
  "suggestions_manage"
  - In the list of suggestions each title should have a "delete" button.
    - Clicking the delete button should trigger a confirmation dialog.
      Both the "OK" and "Cancel" options should work as expected.

Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Owen Leonard 2024-10-30 17:41:45 +00:00 committed by Katrin Fischer
parent 9cfb92c206
commit cc67775b6f
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
View File

@ -882,7 +882,7 @@
</ul>
</div>
[% ELSIF CAN_user_suggestions_suggestions_delete %]
<button data-op="cud-delete" data-suggestionid="[% s.suggestionid | html %]" class="btn btn-default trigger_action">Delete</button>
<button data-op="cud-delete" data-suggestionid="[% s.suggestionid | html %]" class="btn btn-xs btn-default trigger_action"><i class="fa fa-trash-can"></i> Delete</button>
[% END %]
</td>
</tr>
@ -1437,7 +1437,7 @@
$("." + target).toggle();
});
$("button.trigger_action").on("click", function(e) {
$(".trigger_action").on("click", function(e) {
var id = $(this).data('suggestionid');
var op = $(this).data('op');
if ( op == 'cud-delete' && !confirm(_("Are you sure you want to delete this suggestion?")) ) {