From ca27bd4547e81d9db3766a87efad2225bf72f9d8 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Fri, 15 Aug 2025 11:16:49 +0000
Subject: [PATCH] Bug 40585: (follow-up) Display error if no records were found

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit b9bf3609d1fdfbeee1d40e07515717c8024c4c60)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
(cherry picked from commit 5b92e3ba7f30032bc7b4244e960a53b2af807f6c)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 .../modules/virtualshelves/addbybiblionumber.tt   |  3 ++-
 virtualshelves/addbybiblionumber.pl               | 15 +++++++++------
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt
index 03c06326d1..ff45db0c91 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt
@@ -13,10 +13,11 @@
     <div class="container-fluid">
 
 [% UNLESS (authorized) %]
+    <h1>Error adding to list</h1>
     <div class="alert alert-warning">
-        <h1>Error adding to list</h1>
         [% IF (errcode==1) %]<p>Could not create a new list. Please check the name.</p>[% END %]
         [% IF (errcode==2) %]<p>Sorry, you do not have permission to add items to this list.</p>[% END %]
+        [% IF (errcode==3) %]<p>The titles selected were not found</p>[% END %]
         <button class="btn btn-default close_window focus">Close window</button>
     </div>
 [% ELSE %]
diff --git a/virtualshelves/addbybiblionumber.pl b/virtualshelves/addbybiblionumber.pl
index a5e68d8295..ad5cd22877 100755
--- a/virtualshelves/addbybiblionumber.pl
+++ b/virtualshelves/addbybiblionumber.pl
@@ -197,14 +197,17 @@ for my $biblionumber (@biblionumbers) {
         }
     );
 }
-$template->param(
-    multiple => ( scalar(@biblios) > 1 ),
-    total    => scalar @biblios,
-    biblios  => \@biblios,
-);
+
+if ( scalar(@biblios) < 1 ) {
+    $errcode    = 3;
+    $authorized = 0;    # trigger error screen
+}
 
 $template->param(
-    newshelf => $newshelf || 0,
+    multiple   => ( scalar(@biblios) > 1 ),
+    total      => scalar @biblios,
+    biblios    => \@biblios,
+    newshelf   => $newshelf || 0,
     authorized => $authorized,
     errcode    => $errcode,
 );