gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 24147: Don't assume search_related will return ordered values 

This test is failing randomly because it assume the order is always the
same. But it's not.

Note: Koha::Objects->search_related is never used , last use removed from
  commit 9aa724cdf2
  Bug 19599: Speed anonymise_issue_history up
We should keep it however IMO

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit e10dc50328)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit e550f25a01)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
This commit is contained in:
Jonathan Druart 2020-08-20 14:32:43 +02:00 committed by Aleisha Amohia
parent 4eb56562a5
commit c9d3eb03ba
1 changed files with 38 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
t/db_dependent/Koha/Objects.t
View File

@ -142,21 +142,48 @@ subtest 'find' => sub {
};
subtest 'search_related' => sub {
plan tests => 8;
plan tests => 6;
my $builder = t::lib::TestBuilder->new;
my $patron_1 = $builder->build( { source => 'Borrower' } );
my $patron_2 = $builder->build( { source => 'Borrower' } );
my $libraries = Koha::Patrons->search( { -or => { borrowernumber => [ $patron_1->{borrowernumber}, $patron_2->{borrowernumber} ] } } )->search_related('branchcode');
is( ref( $libraries ), 'Koha::Libraries', 'Koha::Objects->search_related should return an instanciated Koha::Objects-based object' );
is( $libraries->count, 2, 'Koha::Objects->search_related should work as expected' );
is( $libraries->next->branchcode, $patron_1->{branchcode}, 'Koha::Objects->search_related should work as expected' );
is( $libraries->next->branchcode, $patron_2->{branchcode}, 'Koha::Objects->search_related should work as expected' );
my $libraries = Koha::Patrons->search(
{
-or => {
borrowernumber =>
[ $patron_1->{borrowernumber}, $patron_2->{borrowernumber} ]
}
}
)->search_related('branchcode');
is( ref($libraries), 'Koha::Libraries',
'Koha::Objects->search_related should return an instanciated Koha::Objects-based object'
);
is( $libraries->count, 2,
'Koha::Objects->search_related should work as expected' );
ok( eq_array(
[ $libraries->get_column('branchcode') ],
[ $patron_1->{branchcode}, $patron_2->{branchcode} ] ),
'Koha::Objects->search_related should work as expected'
);
my @libraries = Koha::Patrons->search( { -or => { borrowernumber => [ $patron_1->{borrowernumber}, $patron_2->{borrowernumber} ] } } )->search_related('branchcode');
is( ref( $libraries[0] ), 'Koha::Library', 'Koha::Objects->search_related should return a list of Koha::Object-based objects' );
is( scalar(@libraries), 2, 'Koha::Objects->search_related should work as expected' );
is( $libraries[0]->branchcode, $patron_1->{branchcode}, 'Koha::Objects->search_related should work as expected' );
is( $libraries[1]->branchcode, $patron_2->{branchcode}, 'Koha::Objects->search_related should work as expected' );
my @libraries = Koha::Patrons->search(
{
-or => {
borrowernumber =>
[ $patron_1->{borrowernumber}, $patron_2->{borrowernumber} ]
}
}
)->search_related('branchcode');
is(
ref( $libraries[0] ), 'Koha::Library',
'Koha::Objects->search_related should return a list of Koha::Object-based objects'
);
is( scalar(@libraries), 2,
'Koha::Objects->search_related should work as expected' );
ok( eq_array(
[ map { $_->branchcode } @libraries ],
[ $patron_1->{branchcode}, $patron_2->{branchcode} ] ),
'Koha::Objects->search_related should work as expected'
);
};
subtest 'single' => sub {