gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 43001: Restore non-priority hold text to reserve/request.pl 

To test:

1. Place a item level hold, making sure to mark it as "Non priority hold"
2. After placing the hold, on reserve/request.pl look at the "Details" column
3. Notice the hold is missing "Non priority hold" text in the details column
4. APPLY PATCH
5. Look again at reserve/request.pl and now the "Non priority hold" text should be restored to 'Details column'

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
This commit is contained in:
Lucas Gass 2026-07-06 15:10:00 +00:00 committed by Pedro Amorim
parent 8b4d69b19d
commit c997f83cdf
No known key found for this signature in database
GPG Key ID: 06B75BA7F3894D55
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
koha-tmpl/intranet-tmpl/prog/js/holds.js
View File

@ -1671,9 +1671,13 @@ async function load_patron_holds_table(biblio_id, split_data) {
const extras = group_hold_message + iso_message;
const non_priority_label = row.non_priority
? `<br/><i>${__("Non priority hold")}</i>`
: "";
// Handle status cases
if (row.status) {
return `<a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=${row.biblio_id}&itemnumber=${row.item_id}">${row.item.external_id}</a>${extras}`;
return `<a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=${row.biblio_id}&itemnumber=${row.item_id}">${row.item.external_id}</a>${non_priority_label}${extras}`;
}
// Handle item level holds
@ -1683,13 +1687,13 @@ async function load_patron_holds_table(biblio_id, split_data) {
const itemLink = `<a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=${row.biblio_id}&itemnumber=${row.item_id}">${barcode.escapeHtml ? barcode.escapeHtml() : barcode}</a>`;
if (row.item_level_holds_count >= 2) {
return `${__("Only item")} ${itemLink}${extras}`;
return `${__("Only item")} ${itemLink}${non_priority_label}${extras}`;
}
return `<select id="change_hold_type" class="change_hold_type ${table_class}" data-id="${row.hold_id}">
<option value="" selected>${__("Only item")} ${barcode}</option>
<option value="">${__("Next available")}</option>
</select>${extras}`;
</select>${non_priority_label}${extras}`;
}
// Handle item group
@ -1697,16 +1701,15 @@ async function load_patron_holds_table(biblio_id, split_data) {
return (
__(
"Next available item from group <strong>%s</strong>"
).format(row.item_group.description) + extras
).format(row.item_group.description) +
non_priority_label +
extras
);
}
// Default: Next available
let message = __("Next available");
if (row.non_priority) {
message += `<br/><i>${__("Non priority hold")}</i>`;
}
return message + extras;
return message + non_priority_label + extras;
},
},
{