gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 37288: Improve display of data provider edit form 

This patch makes some improvements to the edit form for data providers. It delays page display until the counter registry has responded and also improves the display of the "create manually" and "Create from registry" buttons

Test plan:
1) Create a Data provider in the ERM module
2) Click to edit that new provider
3) The page will load and there will be a slight delay before the Data provider name input is populated
4) The "Create manually" button will also be visible
5) Apply patch and yarn build
6) Hard refresh the browser and repeat steps 1 and 2
7) This time when the page loads the provider name should be prepopulated and no manual creation button will be visible

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit b646d8ab65)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit c87b670300)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Matt Blenkinsop 2024-07-17 08:36:16 +00:00 committed by Fridolin Somers
parent 0306c91d56
commit c81fe295db
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersFormAdd.vue
View File

@ -59,7 +59,10 @@
</v-select>
<span class="required">{{ $__("Required") }}</span>
<button
v-if="!manual_form"
v-if="
!manual_form &&
!usage_data_provider.erm_usage_data_provider_id
"
type="button"
style="margin-left: 1em"
@click="createManualProvider()"
@ -67,7 +70,10 @@
{{ $__("Create manually") }}
</button>
<button
v-else
v-if="
manual_form &&
!usage_data_provider.erm_usage_data_provider_id
"
type="button"
style="margin-left: 1em"
@click="createFromRegistry()"
@ -440,7 +446,6 @@ export default {
this.usage_data_provider.report_types =
this.formatReportTypes(usage_data_provider.report_types)
this.getCounterRegistry(usage_data_provider.name, "edit")
this.initialized = true
},
error => {}
)
@ -463,6 +468,7 @@ export default {
)
}
this.searching = false
this.initialized = true
},
error => {}
)