gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 27708: (QA follow-up) Add a few tests for Koha::Edifact::Order 

1. This adds a simple regression test to make sure order_line() method
executes correctly with basket create_items set to "ordering" and
"receiving".

2. A simple test for the filename method is added

To test:
 1) prove t/db_dependent/Koha/Edifact/Order.t

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 8c1ea4ec8a)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Joonas Kylmälä 2021-11-02 23:22:45 +00:00 committed by Fridolin Somers
parent b6a792b14f
commit c60cdb9bfc
1 changed files with 112 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

112
t/db_dependent/Koha/Edifact/Order.t Executable file
View File

@ -0,0 +1,112 @@
#!/usr/bin/perl
# Copyright 2021 Joonas Kylmälä <joonas.kylmala@iki.fi>
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use Test::More tests => 2;
use Koha::Edifact::Order;
use t::lib::TestBuilder;
my $schema = Koha::Database->new->schema;
my $builder = t::lib::TestBuilder->new;
subtest 'order_line() tests' => sub {
# TODO: Split up order_line() to smaller methods in order
# to allow better testing
plan tests => 2;
$schema->storage->txn_begin;
my $biblio = $builder->build_sample_biblio();
my $ean = $builder->build( { source => 'EdifactEan' } );
my $order = $builder->build_object(
{
class => 'Koha::Acquisition::Orders',
value => { biblionumber => $biblio->biblionumber }
}
);
my $vendor = $builder->build(
{
source => 'VendorEdiAccount',
value => {
vendor_id => $order->basket->bookseller->id,
}
}
);
my @orders = $schema->resultset('Aqorder')
->search( { basketno => $order->basket->basketno } )->all;
my $edi_order = Koha::Edifact::Order->new(
{
orderlines => \@orders,
vendor => $vendor,
ean => $ean
}
);
$order->basket->create_items('ordering')->store;
is( $edi_order->order_line( 1, $orders[0] ),
undef, 'Orderline message formed with with "ordering"' );
$order->basket->create_items('receiving')->store;
is( $edi_order->order_line( 1, $orders[0] ),
undef, 'Orderline message formed with "receiving"' );
$schema->storage->txn_rollback;
};
subtest 'filename() tests' => sub {
plan tests => 1;
$schema->storage->txn_begin;
my $ean = $builder->build( { source => 'EdifactEan' } );
my $order =
$builder->build_object( { class => 'Koha::Acquisition::Orders' } );
my $vendor = $builder->build(
{
source => 'VendorEdiAccount',
value => { vendor_id => $order->basket->bookseller->id }
}
);
my @orders = $schema->resultset('Aqorder')
->search( { basketno => $order->basket->basketno } )->all;
my $edi_order = Koha::Edifact::Order->new(
{
orderlines => \@orders,
vendor => $vendor,
ean => $ean
}
);
my $expected_filename = 'ordr' . $order->basket->basketno . '.CEP';
is( $edi_order->filename, $expected_filename,
'Filename is formed from the basket number' );
$schema->storage->txn_rollback;
};