gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 16447: Remove occurrence of the borrow permission which does no longer exist 

Bug 7976 has removed this permission, but other patches re-added it...
Note that the occurrences in sendbasket.pl, edithelp.pl, opac/svc/login should
have been removed by bug 7976.

Test plan:
  git grep 'borrow.*=> 1'
should not return any results.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2016-05-05 14:52:04 +01:00 committed by Brendan Gallagher
parent f4936b5763
commit c4eabeda0b
7 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
basket/sendbasket.pl
View File

@ -59,7 +59,7 @@ if ( $email_add ) {
query => $query, query => $query,
type => "intranet", type => "intranet",
authnotrequired => 0, authnotrequired => 0,
flagsrequired => { borrow => 1 }, flagsrequired => { catalogue => 1 },
} }
); );

1
edithelp.pl
View File

@ -52,7 +52,6 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
borrowers => 1, borrowers => 1,
permissions => 1, permissions => 1,
reserveforothers => 1, reserveforothers => 1,
borrow => 1,
reserveforself => 1, reserveforself => 1,
editcatalogue => 1, editcatalogue => 1,
updatecharges => 1, updatecharges => 1,

1
opac/opac-idref.pl
View File

@ -37,7 +37,6 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
query => $cgi, query => $cgi,
type => "opac", type => "opac",
authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ), authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),
flagsrequired => { borrow => 1 },
} }
); );

1
opac/opac-news-rss.pl
View File

@ -34,7 +34,6 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
type => "opac", type => "opac",
query => $input, query => $input,
authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ), authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),
flagsrequired => { borrow => 1 },
} }
); );

1
opac/opac-restrictedpage.pl
View File

@ -40,7 +40,6 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
query => $query, query => $query,
type => "opac", type => "opac",
authnotrequired => $withinNetwork, authnotrequired => $withinNetwork,
flagsrequired => { borrow => 1 },
debug => 1, debug => 1,
} }
); );

2
opac/svc/login
View File

@ -43,7 +43,7 @@ if ( $response->is_success ) {
my $content = $response->decoded_content(); my $content = $response->decoded_content();
my $decoded_json = decode_json($content); my $decoded_json = decode_json($content);
my ( $userid, $cookie, $sessionID ) = my ( $userid, $cookie, $sessionID ) =
checkauth( $query, 1, { borrow => 1 }, 'opac', $decoded_json->{'email'} ); checkauth( $query, 1, {}, 'opac', $decoded_json->{'email'} );
if ($userid) { # a valid user has logged in if ($userid) { # a valid user has logged in
print $query->header( -cookie => $cookie ); print $query->header( -cookie => $cookie );
print $decoded_json; print $decoded_json;

2
t/db_dependent/Auth.t
View File

@ -37,7 +37,7 @@ $dbh->{RaiseError} = 1;
# we don't need to bother about permissions for this test # we don't need to bother about permissions for this test
my $flags = { my $flags = {
superlibrarian => 1, acquisition => 0, superlibrarian => 1, acquisition => 0,
borrow => 0, borrowers => 0, borrowers => 0,
catalogue => 1, circulate => 0, catalogue => 1, circulate => 0,
coursereserves => 0, editauthorities => 0, coursereserves => 0, editauthorities => 0,
editcatalogue => 0, management => 0, editcatalogue => 0, management => 0,