Bug 39838: Fix uses of `alias_id`

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorDetails.vue

@@ -65,7 +65,7 @@
                 <ul style="margin-left: 8rem">
                     <li
                         v-for="(alias, i) in vendor.aliases"
-                        :key="alias.alias_id"
+                        :key="alias.vendor_alias_id"
                     >
                         {{ $__("Alias") + " " + (i + 1) }}: {{ alias.alias }}
                     </li>

t/cypress/support/e2e.js

@@ -1355,7 +1355,7 @@ cy.get_vendors_to_relate = () => {
         {
             id: 2,
             name: "My Vendor 2",
-            aliases: [{ alias: "alias", alias_id: 1, vendor_id: 2 }],
+            aliases: [{ alias: "alias", vendor_alias_id: 1, vendor_id: 2 }],
         },
     ];
 };