gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 25751: Add ORDERED in dropdown list of suggestion's statuses 

The status "ORDERED" is missing from the pull down list of
status values when editing a suggestion, so the first
option is selected "No status".

This leads to data loss when editing a suggestion in the
status "ORDERED". Worse: the status can't be reset to
"ORDERED" and so no AVAILABLE notice can be sent to the patron.

Test plan:
- Create a suggestion, accept it, create a new order from this suggestion.
- Verify status is "ORDERED"
- Edit the suggestion
=> Without this patch the dropdown list does not have
   "Ordered", and if you save you lost the status
=> With this patch applied the dropdown list has "Ordered"
   preselected. You can save and preserve the status.

Signed-off-by: Holly Cooper <hc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit eeb7ac6fc0)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2020-06-16 15:44:40 +02:00 committed by Lucas Gass
parent 3bbf638449
commit c320dfa3be
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
View File

@ -343,6 +343,12 @@
<option value="REJECTED">Rejected</option>
[% END %]
[% IF ( statusselected_ORDERED ) %]
<option value="ORDERED" selected="selected">Ordered</option>
[% ELSE %]
<option value="ORDERED">Ordered</option>
[% END %]
[% FOREACH s IN SuggestionStatuses %]
[% IF s.authorised_value == suggestion.STATUS %]
<option value="[% s.authorised_value | html %]" selected="selected">[% s.lib | html %]</option>
@ -681,6 +687,12 @@
<option value="REJECTED">Rejected</option>
[% END %]
[% IF ( statusselected_ORDERED ) %]
<option value="ORDERED" selected="selected">Ordered</option>
[% ELSE %]
<option value="ORDERED">Ordered</option>
[% END %]
[% FOREACH s IN SuggestionStatuses %]
<option value="[% s.authorised_value | html %]">[% s.lib | html %]</option>
[% END %]
@ -841,6 +853,12 @@
<option value="REJECTED">Rejected</option>
[% END %]
[% IF ( statusselected_ORDERED ) %]
<option value="ORDERED" selected="selected">Ordered</option>
[% ELSE %]
<option value="ORDERED">Ordered</option>
[% END %]
[% FOREACH s IN SuggestionStatuses %]
[% IF s.authorised_value == selected_status %]
<option value="[% s.authorised_value | html %]" selected="selected">[% s.lib | html %]</option>