Bug 22784: (QA follow-up) booleans should be TINYINT

As per the coding guidelines, they should be TINYINT(1).

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Tomas Cohen Arazi 2020-04-14 17:02:24 -03:00 committed by Martin Renvoize
parent ae297d8f02
commit c0f79717ee
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
3 changed files with 6 additions and 6 deletions

View File

@ -99,7 +99,7 @@ __PACKAGE__->table("suggestions");
=head2 archived
data_type: 'integer'
data_type: 'tinyint'
default_value: 0
is_nullable: 0
@ -259,7 +259,7 @@ __PACKAGE__->add_columns(
size => 10,
},
"archived",
{ data_type => "integer", default_value => 0, is_nullable => 0 },
{ data_type => "tinyint", default_value => 0, is_nullable => 0 },
"note",
{ data_type => "longtext", is_nullable => 1 },
"author",
@ -484,8 +484,8 @@ __PACKAGE__->belongs_to(
);
# Created by DBIx::Class::Schema::Loader v0.07046 @ 2020-03-27 06:55:24
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:shHAnURjxdagQdgu90WQuw
# Created by DBIx::Class::Schema::Loader v0.07046 @ 2020-04-14 20:04:28
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:BrvQGdgqpODl23IfwbqdUw
__PACKAGE__->belongs_to(
"suggester",

View File

@ -3014,7 +3014,7 @@ CREATE TABLE `suggestions` ( -- purchase suggestions
lastmodificationby INT(11) default NULL, -- borrowernumber for the librarian who edit the suggestion for the last time
lastmodificationdate date default NULL, -- date of the last modification
`STATUS` varchar(10) NOT NULL default '', -- suggestion status (ASKED, CHECKED, ACCEPTED, or REJECTED)
`archived` INT(1) NOT NULL DEFAULT 0, -- is the suggestion archived?
`archived` TINYINT(1) NOT NULL DEFAULT 0, -- is the suggestion archived?
`note` LONGTEXT, -- note entered on the suggestion
`author` varchar(80) default NULL, -- author of the suggested item
`title` varchar(255) default NULL, -- title of the suggested item

View File

@ -21546,7 +21546,7 @@ $DBversion = '19.12.00.069';
if( CheckVersion( $DBversion ) ) {
if( !column_exists( 'suggestions', 'archived' ) ) {
$dbh->do(q|
ALTER TABLE suggestions ADD COLUMN archived INT(1) NOT NULL DEFAULT 0 AFTER `STATUS`;
ALTER TABLE suggestions ADD COLUMN archived TINYINT(1) NOT NULL DEFAULT 0 AFTER `STATUS`;
|);
}