gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 18936: Fix several issues 

Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Jonathan Druart 2018-12-07 15:18:20 -03:00 committed by Martin Renvoize
parent f7644cf307
commit c004887e33
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Koha/CirculationRules.pm
View File

@ -240,14 +240,15 @@ sub get_effective_rules {
sub set_rule {
my ( $self, $params ) = @_;
for my $mandatory_parameter (qw( branchcode categorycode itemtype rule_name rule_value ) ) {
for my $mandatory_parameter (qw( rule_name rule_value ) ) {
Koha::Exceptions::MissingParameter->throw(
"Required parameter 'branchcode' missing")
"Required parameter '$mandatory_parameter' missing")
unless exists $params->{$mandatory_parameter};
}
my $kind_info = $RULE_KINDS->{ $params->{rule_name} };
croak "set_rule given unknown rule '$params->{rule_name}'!"
Koha::Exceptions::MissingParameter->throw(
"set_rule given unknown rule '$params->{rule_name}'!")
unless defined $kind_info;
# Enforce scope; a rule should be set for its defined scope, no more, no less.