Ensure op is defined in serials scripts

Set $op to an empty string if no value passed
otherwise the error-log fills with warnings on comparison
This commit is contained in:
Colin Campbell 2009-09-16 12:18:11 +01:00 committed by Galen Charlton
parent beae9c35b7
commit bfad238475
6 changed files with 7 additions and 8 deletions

View File

@ -31,7 +31,7 @@ use C4::Context;
my $query = new CGI;
my $op = $query->param('op');
my $op = $query->param('op') || q{};
my $dbh = C4::Context->dbh;
my $sth;
@ -51,7 +51,6 @@ my @subscriptionid = $query->param('subscriptionid');
my $subscriptiondescs ;
my $subscriptions;
$op ||= q{};
if($op eq 'gennext' && @subscriptionid){
my $subscriptionid = $subscriptionid[0];
my $subscription = GetSubscription($subscriptionid);

View File

@ -75,7 +75,7 @@ use C4::Serials;
use C4::Branch; # GetBranches
my $query = new CGI;
my $op = $query->param('op');
my $op = $query->param('op') || q{};
my $dbh = C4::Context->dbh;
my $subscriptionid = $query->param('subscriptionid');
# my $auser = $query->param('user');

View File

@ -25,7 +25,7 @@ use C4::Context;
use C4::Serials;
my $query = new CGI;
my $op = $query->param('op');
my $op = $query->param('op') || q{};
my $dbh = C4::Context->dbh;
my $subscriptionid = $query->param('subscriptionid');
my $auser = $query->param('user');

View File

@ -60,7 +60,7 @@ use C4::Biblio;
my $input=new CGI;
# my $type=$query->param('type');
my $op = $input->param('op');
my $op = $input->param('op') || q{};
my $dbh = C4::Context->dbh;
my $startfrom=$input->param('startfrom');

View File

@ -28,7 +28,7 @@ use Date::Calc qw/Today Day_of_Year Week_of_Year Add_Delta_Days/;
use Carp;
my $query = new CGI;
my $op = $query->param('op');
my $op = $query->param('op') || q{};
my $dbh = C4::Context->dbh;
my ($template, $loggedinuser, $cookie, $hemisphere);
my $subscriptionid = $query->param('subscriptionid');
@ -36,7 +36,7 @@ my $subs = GetSubscription($subscriptionid);
$subs->{enddate} = GetExpirationDate($subscriptionid);
if ($op && $op eq 'del') {
if ( $op eq 'del') {
if ($subs->{'cannotedit'}){
carp "Attempt to delete subscription $subscriptionid by ".C4::Context->userenv->{'id'}." not allowed";
print $query->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid");

View File

@ -59,7 +59,7 @@ my $query = new CGI;
my $dbh = C4::Context->dbh;
my $mode = $query->param('mode');
my $op = $query->param('op');
my $op = $query->param('op') || q{};
my $subscriptionid = $query->param('subscriptionid');
my $done = 0; # for after form has been submitted
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(