gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 19936: Remove the subroutine Generate_Userid 

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Jonathan Druart 2018-01-09 10:27:34 -03:00
parent 7b1d08df0f
commit bebf7d17c9
1 changed files with 0 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
C4/Members.pm
View File

@ -86,7 +86,6 @@ BEGIN {
#Check data
push @EXPORT, qw(
&checkuserpassword
&Generate_Userid
&fixup_cardnumber
&checkcardnumber
);
@ -482,38 +481,6 @@ sub AddMember {
return $data{borrowernumber};
}
=head2 Generate_Userid
my $newuid = Generate_Userid($borrowernumber, $firstname, $surname);
Generate a userid using the $surname and the $firstname (if there is a value in $firstname).
$borrowernumber is optional (i.e. it can contain a blank value). A value is passed when generating a new userid for an existing borrower. When a new userid is created for a new borrower, a blank value is passed to this sub.
return :
new userid ($firstname.$surname if there is a $firstname, or $surname if there is no value in $firstname) plus offset (0 if the $newuid is unique, or a higher numeric value if not unique).
=cut
sub Generate_Userid {
my ($borrowernumber, $firstname, $surname) = @_;
my $newuid;
my $offset = 0;
my $patron = Koha::Patron->new;
#The script will "do" the following code and increment the $offset until the generated userid is unique
do {
$firstname =~ s/[[:digit:][:space:][:blank:][:punct:][:cntrl:]]//g;
$surname =~ s/[[:digit:][:space:][:blank:][:punct:][:cntrl:]]//g;
$newuid = lc(($firstname)? "$firstname.$surname" : $surname);
$newuid = unac_string('utf-8',$newuid);
$newuid .= $offset unless $offset == 0;
$patron->userid( $newuid );
$offset++;
} while (! $patron->has_valid_userid );
return $newuid;
}
=head2 fixup_cardnumber
Warning: The caller is responsible for locking the members table in write