Bug 30120: Save and apply extended attributes during self registration verification by email

The self registration form stores a new borrower as a borrower modification when verifying by email.

Borrower modifications can  handle extended attributes.

This patch simply sotres the extended attributes in the modifications table, and approves a modification
to the extended attributes only after patron is created

To test:
1 - Apply patch
2 - Create a patron attribute and set it as viewable/editable in the OPAC
3 - Set system preference PatronSelfRegistrationVerifyByEmail
4 - Reigster a new patron on the OPAC, provide an email and populate the extended attribute
5 - Retrieve the verification token, the last on in the messages table
    SELECT * FROM message_queue;
6 - Go tot he url from above
7 - Confirm successful patron creation
8 - View patron record and confirm attribute was set

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Nick Clemens 2022-02-17 14:02:35 +00:00 committed by Fridolin Somers
parent b69afd96db
commit bcfc1bea3e
4 changed files with 11 additions and 3 deletions

View File

@ -165,7 +165,7 @@ Patron attribute types &rsaquo; Administration &rsaquo; Koha
[% ELSE %]
<input type="checkbox" id="opac_editable" name="opac_editable" />
[% END %]
<span class="hint">Check to allow patrons to edit this attribute from their details page in the OPAC. (Requires above, does not work during <a href="/cgi-bin/koha/admin/preferences.pl?op=search&amp;searchfield=PatronSelfRegistration" target="_blank">self-registration</a> if <a href="/cgi-bin/koha/admin/preferences.pl?op=search&amp;searchfield=PatronSelfRegistrationVerifyByEmail" target="_blank">PatronSelfRegistrationVerifyByEmail</a> is set.)</span>
<span class="hint">Check to allow patrons to edit this attribute from their details page in the OPAC. (Requires above)</span>
</li>
<li><label for="staff_searchable">Searchable: </label>
[% IF attribute_type AND attribute_type.staff_searchable %]

View File

@ -886,7 +886,7 @@
</div> <!-- /.row -->
[% END %]
[% IF ( Koha.Preference('ExtendedPatronAttributes') && patron_attribute_classes.size && ! ( action == 'new' && Koha.Preference('PatronSelfRegistrationVerifyByEmail') ) ) %]
[% IF ( Koha.Preference('ExtendedPatronAttributes') && patron_attribute_classes.size ) %]
<div class="row">
<div class="col">
[% FOREACH pa_class IN patron_attribute_classes %]

View File

@ -190,6 +190,7 @@ if ( $action eq 'create' ) {
$borrower{password} = Koha::AuthUtils::generate_password(Koha::Patron::Categories->find($borrower{categorycode})) unless $borrower{password};
$borrower{verification_token} = $verification_token;
$borrower{extended_attributes} = to_json($attributes);
Koha::Patron::Modification->new( \%borrower )->store();
#Send verification email

View File

@ -67,12 +67,19 @@ if (
delete $patron_attrs->{timestamp};
delete $patron_attrs->{verification_token};
delete $patron_attrs->{changed_fields};
delete $patron_attrs->{extended_attributes};
my $patron = Koha::Patron->new( $patron_attrs )->store;
Koha::Patron::Consent->new({ borrowernumber => $patron->borrowernumber, type => 'GDPR_PROCESSING', given_on => $consent_dt })->store if $consent_dt;
if ($patron) {
$m->delete();
if( $m->extended_attributes ){
$m->borrowernumber( $patron->borrowernumber);
$m->changed_fields(['extended_attributes']);
$m->approve();
} else {
$m->delete();
}
C4::Form::MessagingPreferences::handle_form_action($cgi, { borrowernumber => $patron->borrowernumber }, $template, 1, C4::Context->preference('PatronSelfRegistrationDefaultCategory') ) if C4::Context->preference('EnhancedMessagingPreferences');
$template->param( password_cleartext => $patron->plain_text_password );