gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 25237: Fix semantic heading for opac-details 

Prior to this patch the opac-details view contained semantically incorrect h3
headings for the author information.

Test plan
1/ Perform a search in the OPAC that will yield results
2/ Navigate to any results detailed view
3/ Inspect the page and note that there are semantically incorrect headings
   H1 (Page title) > H2 (Item title) > H5 (Author)
4/ Apply the patch
5/ Reload the page
6/ Inspect the page and note that the semantically incorrect author block has
   been converted to a span with an 'h3' class for styling
7/ Note the page still appears nicely
8/ Signoff

Bonus points: Check with XSLT views enabled and disabled.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 6b49a70b94)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Martin Renvoize 2020-06-11 12:45:57 +01:00 committed by Lucas Gass
parent 3a9597ea48
commit bb805283f6
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
View File

@ -131,7 +131,7 @@
[% XSLTBloc | $raw %]
[% ELSE %]
<h2 class="title">[% INCLUDE 'biblio-title.inc' %]</h2>
[% IF ( author ) %]<h5 class="author">by <a class="contributors" href="/cgi-bin/koha/opac-search.pl?q=au:[% author |url %]">[% author | html %]</a></h5>[% END %]
[% IF ( author ) %]<span class="results_summary author h3">by <a class="contributors" href="/cgi-bin/koha/opac-search.pl?q=au:[% author |url %]">[% author | html %]</a></span>[% END %]
<span class="results_summary">[% UNLESS ( item_level_itypes ) %]
[

8
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
View File

@ -160,14 +160,14 @@
<!-- Author Statement: Alternate Graphic Representation (MARC 880) -->
<xsl:if test="$display880">
<h5 class="author">
<span class="results_summary author h3">
<xsl:call-template name="m880Select">
<xsl:with-param name="basetags">100,110,111,700,710,711</xsl:with-param>
<xsl:with-param name="codes">abc</xsl:with-param>
<xsl:with-param name="index">au</xsl:with-param>
<!-- do not use label 'by ' here, it would be repeated for every occurrence of 100,110,111,700,710,711 -->
</xsl:call-template>
</h5>
</span>
</xsl:if>
<!--#13382 Added Author Statement to separate Authors and Contributors -->
@ -1566,7 +1566,7 @@
<xsl:param name="materialTypeLabel" />
<xsl:param name="theme" />
<xsl:if test="count($authorfield)&gt;0">
<h5 class="author">
<span class="results_summary author h3">
<xsl:for-each select="$authorfield">
<xsl:choose>
<xsl:when test="position()&gt;1"/>
@ -1832,7 +1832,7 @@
<xsl:when test="position()=last()"><xsl:text></xsl:text></xsl:when><xsl:otherwise><span class="separator"><xsl:text> | </xsl:text></span></xsl:otherwise>
</xsl:choose>
</xsl:for-each>
</h5>
</span>
</xsl:if>
</xsl:template>