gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 42606: Check for default framework earlier 

The code switches 'Default' to '' - we should just do it immediately after fetching from the template

1 - From the cataloging home page, click "New from Z39.50" without choosing a framework in the dropdown menu.
2 - Perform a Z39.50 search in the popup window, then click "Import" for one of the results. This triggers an error in the parent window:
3 - Error:Can't call method "is_fast_add" on an undefined value at /kohadevbox/koha/cataloguing/addbiblio.pl line 518
4 - Apply patch
5 - Reload and repeat
6 - Success!

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Jan Kissig <bibliothek@th-wildau.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Nick Clemens 2026-05-14 14:25:38 +00:00 committed by Lucas Gass
parent 7cdae514a4
commit bb47a5ffe6
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
cataloguing/addbiblio.pl
View File

@ -489,14 +489,15 @@ sub build_tabs {
# ========================
# MAIN
#=========================
my $input = CGI->new;
my $error = $input->param('error');
my $biblionumber = $input->param('biblionumber'); # if biblionumber exists, it's a modif, not a new biblio.
my $parentbiblio = $input->param('parentbiblionumber');
my $breedingid = $input->param('breedingid');
my $z3950 = $input->param('z3950');
my $mode = $input->param('mode') // q{};
my $frameworkcode = $input->param('frameworkcode');
my $input = CGI->new;
my $error = $input->param('error');
my $biblionumber = $input->param('biblionumber'); # if biblionumber exists, it's a modif, not a new biblio.
my $parentbiblio = $input->param('parentbiblionumber');
my $breedingid = $input->param('breedingid');
my $z3950 = $input->param('z3950');
my $mode = $input->param('mode') // q{};
my $frameworkcode = $input->param('frameworkcode');
$frameworkcode = '' if ( $frameworkcode eq 'Default' );
my $redirect = $input->param('redirect');
my $searchid = $input->param('searchid') // "";
my $dbh = C4::Context->dbh;
@ -534,8 +535,6 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
}
);
$frameworkcode = '' if ( $frameworkcode eq 'Default' );
# Set default values for global variable
$tagslib = &GetMarcStructure( 1, $frameworkcode );
$usedTagsLib = &GetUsedMarcStructure($frameworkcode);