gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 24323: Advanced editor - Display an error message if the record did not save 

Invalid 008 with helper silently fails to save.

This patch adds a "else if" to fall through if the error message isn't
one of the previously defined ones ("syntax" and "invalid") and presents
the human with a generic message that "Something went wrong, cannot
save."

Prior to testing:
a/Verify that Advanced Editor is enabled
b/Download the errorrecord.mrc from bug

To test:
1/Apply patch
2/Go to Cataloging->Advanced Editor
3/Click "Import Record" button and navigate to the record saved from
step b/
4/Add an 003 field (as required by the default cataloging config)
5/Hit "Save to catalog"
6/Verify that a message is passed to the user that the file was unable
to be saved

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Cori Lynn Arnold 2019-12-31 17:10:14 +00:00 committed by Martin Renvoize
parent a12fca041c
commit bae538dcdd
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
View File

@ -881,6 +881,8 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr
humanMsg.displayAlert( _("Incorrect syntax, cannot save"), { className: 'humanError' } );
} else if ( result.error == 'invalid' ) {
humanMsg.displayAlert( _("Record structure invalid, cannot save"), { className: 'humanError' } );
} else if ( result.error ) {
humanMsg.displayAlert( _("Something went wrong, cannot save"), { className: 'humanError' } );
} else if ( !result.error ) {
humanMsg.displayAlert( _("Record saved "), { className: 'humanSuccess' } );
}