Bug 34946: Remove the use of event attributes from self checkout and check-in

This patch removes the use of event attributes from the self checkout
and self check-in templates. These events are defined now along with the
other in-page JS.

To test you must have SelfCheckInModule and WebBasedSelfCheck
preferences enabled. And SelfCheckoutByLogin = cardnumber.

- Navigate to the self checkout interface
  (/cgi-bin/koha/sco/sco-main.pl).
- When the page loads, cursor focus should be automatically placed in
  the barcode field.
- Test the "munge history" feature from Bug 10016:
  [1] Start a web-based self-check session.
  [2] Enter a patron barcode.
  [3] Allow the self-check session to time out.
  [4] Use the back button.  You should get the patron barcode
      entry form; you should not be prompted to resubmit form input.
  [5] Enter a patron barcode, perform some transactions, then
      use the finish button.
  [6] Next, use the back button.  You should get the patron barcode
      entry form.
- Test the updated checkout_confirm function by submitting the "magic"
  barcode for checkout: __KOHA_NEW_CIRC__. The user's session should be
  ended.

- Navigate to the self check-in interface
  (/cgi-bin/koha/sco/sci-main.pl).
- Test the cursor focus and "munge history" feature on this page too.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 76d522a903)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Owen Leonard 2023-09-28 12:48:36 +00:00 committed by Fridolin Somers
parent 748ea28983
commit b27a2a2eb0
2 changed files with 22 additions and 3 deletions

View File

@ -51,7 +51,7 @@
[% Asset.js('js/Gettext.js') | $raw %]
[% Asset.js('js/i18n.js') | $raw %]
</head>
<body id="sci_main" class="sci" onload="dofocus();" onunload="mungeHistory();">
<body id="sci_main" class="sci">
[% INCLUDE 'masthead-sci.inc' %]
<div class="main">
@ -209,6 +209,14 @@
var barcodes = [];
$( window ).on( "load", function() {
dofocus();
});
$( window ).on( "unload", function() {
mungeHistory();
});
$(document).ready(function() {
// Barcodes scanning table initially hidden
$("#sci_barcodes_table").hide();

View File

@ -32,7 +32,7 @@
[% Asset.js('js/Gettext.js') | $raw %]
[% Asset.js('js/i18n.js') | $raw %]
</head>
<body id="sco_main" class="sco" onload="dofocus();" onunload="mungeHistory();">
<body id="sco_main" class="sco">
[% INCLUDE 'masthead-sco.inc' %]
<div class="main">
@ -241,7 +241,7 @@
[% IF ( validuser ) %]
<div id="newcheckout" class="sco_entry">
<form id="scan_form" name="scan_form" method="post" action="/cgi-bin/koha/sco/sco-main.pl" onsubmit="return checkout_confirm('[% patronid | html %]');">
<form id="scan_form" name="scan_form" method="post" action="/cgi-bin/koha/sco/sco-main.pl">
<legend><h2>
[% IF ( Koha.Preference('SCOAllowCheckin') ) %]
<span>Check out, return, or renew an item:</span>
@ -499,6 +499,13 @@
}
[% END %]
$( window ).on( "load", function() {
dofocus();
});
$( window ).on( "unload", function() {
mungeHistory();
});
$(document).ready(function() {
dofocus();
@ -533,6 +540,10 @@
return true;
});
$("#scan_form").on("submit", function(){
return checkout_confirm('[% patronid | html %]');
});
});
</script>