Bug 32551: HTTP_ACCEPT_LANGUAGE legacy CGI variable not set in Mojolicious
This patch addresses the fact some of our code still relies on those CGI-era ENV variables. In particular, C4::Laguages::getlanguage expects it to calculate the most suitable language. As this is reported as required, I provide a fix. I did a `git grep HTTP_` on the codebase, and the only other occurences are: * C4::Output (HTTP_X_REQUESTED_WITH) * C4::Context (HTTP_USER_AGENT, HTTP_X_FORWARDED_FOR) * C4::Auth_with_shibboleth (using HTTP_ variables for matchpoints) * Some handling on the 'Koha as a Mojo app' code * Some .pl script not relevant to this report I decided to limit this patch to the requested header which seems harmless. I leave the other cases. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ qa -c 1 => FAIL: Tests fail! 3. Apply this patch 4. Run: k$ qa -c 2 => SUCCESS: Tests pass! All green! 5. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: wainuiwitikapark <wainuiwitikapark@catalyst.net.nz>
This commit is contained in:
parent
4c906a7533
commit
b141d60c8b
|
|
@ -160,6 +160,11 @@ sub authenticate_api_request {
|
|||
$c->stash_embed( { spec => $spec } );
|
||||
$c->stash_overrides();
|
||||
|
||||
# FIXME: Remove once CGI is not used
|
||||
my $accept_language = $c->req->headers->accept_language;
|
||||
$ENV{HTTP_ACCEPT_LANGUAGE} = $accept_language
|
||||
if $accept_language;
|
||||
|
||||
my $cookie_auth = 0;
|
||||
|
||||
my $authorization = $spec->{'x-koha-authorization'};
|
||||
|
|
|
|||
Loading…
Reference in New Issue