Bug 34380: Fix inconsistencies in Item types page titles, breadcrumbs, and header

This patch fixes inconsistencies in the item type administration page so
that page titles, breadcrumb navigation, and page headers are consistent
with each other and with other pages in Koha.

To test, apply the patch and go to Administration -> Item types. Check
each variation of the page to confirm that everything looks correct:

- Item types list
 - New item type
 - Edit item type
 - Confirm deletion of item type

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2023-09-05 17:06:51 +00:00 committed by Tomas Cohen Arazi
parent 766bdd638a
commit b0342302a0
No known key found for this signature in database
GPG Key ID: 0A272EA1B2F3C15F
1 changed files with 9 additions and 9 deletions

View File

@ -13,14 +13,14 @@
[% IF ( itemtype ) %]
[% tx("Modify item type '{item_type}'", { item_type = itemtype.itemtype }) | html %]
[% ELSE %]
[% t("Add item type") | html %]
[% t("New item type") | html %]
[% END %] &rsaquo;
[% END %]
[% IF op == 'delete_confirm' %]
[% IF ( total ) %]
[% tx("Cannot delete item type '{item_type}'", { item_type = itemtype.itemtype }) | html %]
[% ELSE %]
[% tx("Delete item type '{item_type}'?", { item_type = itemtype.itemtype }) | html %]
[% tx("Confirm deletion of item type '{item_type}'?", { item_type = itemtype.itemtype }) | html %]
[% END %] &rsaquo;
[% END %]
[% IF op == 'delete_confirmed' %]
@ -72,11 +72,11 @@
[% IF op == 'add_form' %]
[% IF itemtype %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Modify item type '[% itemtype.itemtype | html %]'</span>
[% tx("Modify item type '{item_type}'", { item_type = itemtype.itemtype }) | html %]
[% END %]
[% ELSE %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Add item type</span>
<span>New item type</span>
[% END %]
[% END %]
[% END %]
@ -84,11 +84,11 @@
[% IF op == 'delete_confirm' %]
[% IF total %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Cannot delete item type '[% itemtype.itemtype | html %]'</span>
[% tx("Cannot delete item type '{item_type}'", { item_type = itemtype.itemtype }) | html %]
[% END %]
[% ELSE %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Delete item type '[% itemtype.itemtype | html %]'?</span>
[% tx("Confirm deletion of item type '{item_type}'?", { item_type = itemtype.itemtype }) | html %]
[% END %]
[% END %]
[% END %]
@ -144,9 +144,9 @@
[% IF op == 'add_form' %]
[% IF itemtype %]
<h1>Modify item type</h1>
<h1>[% tx("Modify item type '{item_type}'", { item_type = itemtype.itemtype }) | html %]</h1>
[% ELSE %]
<h1>Add item type</h1>
<h1>New item type</h1>
[% END %]
<form action="/cgi-bin/koha/admin/itemtypes.pl" name="Aform" method="post" id="itemtypeentry">
<input type="hidden" name="op" value="add_validate" />
@ -354,7 +354,7 @@
[% IF op == 'delete_confirm' %]
<div class="dialog alert">
<h1>Delete item type '[% itemtype.itemtype | html %]'?</h1>
<h1>[% tx("Are you sure you want to delete item type '{item_type}'?", { item_type = itemtype.itemtype }) | html %]</h1>
<table>
<tr>
<th scope="row">Item type</th>