gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 37734: Fix insert runtime parameter button in reports 

The drop down item links had two class attributes which
prevented javascript from opening the modal.
This patch combines the classes into one class attribute.

To test:
1. Go to Reports > Create from SQL
2. Click the Insert runtime parameter button
3. Click on any of the drop down options
4. Nothing happens :(
5. Apply patch
6. Repeat steps 2 and 3 for all different parameters
7. Notice the modal launches :)
8. Confirm the parameters are inserted as expected

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Brendan Lawlor 2024-08-26 15:02:34 +00:00 committed by Katrin Fischer
parent 4f52463551
commit afda7bcc94
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
View File

@ -2552,18 +2552,18 @@
Insert runtime parameter
</button>
<ul class="dropdown-menu">
<li><a class="dropdown-item" href="#" class="insertParam" id="insertAuthVal">Authorized values</a></li>
<li><a class="dropdown-item" href="#" class="insertParam" id="insertFramework">Bibliographic framework</a></li>
<li><a class="dropdown-item" href="#" class="insertParam" id="insertCnSource">Classification sources</a></li>
<li><a class="dropdown-item" href="#" class="insertParam" id="insertDate">Date</a></li>
<li><a class="dropdown-item" href="#" class="insertParam" id="insertItemtypes">Item types</a></li>
<li><a class="dropdown-item" href="#" class="insertParam" id="insertBranches">Libraries</a></li>
<li><a class="dropdown-item" href="#" class="insertParam" id="insertList">List</a></li>
<li><a class="dropdown-item" href="#" class="insertParam" id="insertCategorycode">Patron categories</a></li>
<li><a class="dropdown-item" href="#" class="insertParam" id="insertCashregister">Cash registers</a></li>
<li><a class="dropdown-item" href="#" class="insertParam" id="insertDebittypes">Debit types</a></li>
<li><a class="dropdown-item" href="#" class="insertParam" id="insertCredittypes">Credit types</a></li>
<li><a class="dropdown-item" href="#" class="insertParam" id="insertText">Text field</a></li>
<li><a class="dropdown-item insertParam" href="#" id="insertAuthVal">Authorized values</a></li>
<li><a class="dropdown-item insertParam" href="#" id="insertFramework">Bibliographic framework</a></li>
<li><a class="dropdown-item insertParam" href="#" id="insertCnSource">Classification sources</a></li>
<li><a class="dropdown-item insertParam" href="#" id="insertDate">Date</a></li>
<li><a class="dropdown-item insertParam" href="#" id="insertItemtypes">Item types</a></li>
<li><a class="dropdown-item insertParam" href="#" id="insertBranches">Libraries</a></li>
<li><a class="dropdown-item insertParam" href="#" id="insertList">List</a></li>
<li><a class="dropdown-item insertParam" href="#" id="insertCategorycode">Patron categories</a></li>
<li><a class="dropdown-item insertParam" href="#" id="insertCashregister">Cash registers</a></li>
<li><a class="dropdown-item insertParam" href="#" id="insertDebittypes">Debit types</a></li>
<li><a class="dropdown-item insertParam" href="#" id="insertCredittypes">Credit types</a></li>
<li><a class="dropdown-item insertParam" href="#" id="insertText">Text field</a></li>
</ul>
</div>
[% END %]