gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 26232: Test for empty smart rule fine grace period 

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit f6d614d459)
This commit is contained in:
Didier Gautheron 2020-08-18 07:39:53 +02:00 committed by Lucas Gass
parent aeb33f91a5
commit aec2d4a8f6
1 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
t/db_dependent/Circulation.t
View File

@ -2106,7 +2106,7 @@ subtest 'AddReturn + CumulativeRestrictionPeriods' => sub {
};
subtest 'AddReturn + suspension_chargeperiod' => sub {
plan tests => 24;
plan tests => 27;
my $library = $builder->build( { source => 'Branch' } );
my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
@ -2155,6 +2155,38 @@ subtest 'AddReturn + suspension_chargeperiod' => sub {
}
);
# Same with undef firstremind
Koha::CirculationRules->search->delete;
Koha::CirculationRules->set_rules(
{
categorycode => '*',
itemtype => '*',
branchcode => '*',
rules => {
issuelength => 1,
firstremind => undef, # 0 day of grace
finedays => 2, # 2 days of fine per day of overdue
suspension_chargeperiod => 1,
lengthunit => 'days',
}
}
);
{
my $now = dt_from_string;
my $five_days_ago = $now->clone->subtract( days => 5 );
# We want to charge 2 days every day, without grace
# With 5 days of overdue: 5 * Z
my $expected_expiration = $now->clone->add( days => ( 5 * 2 ) / 1 );
test_debarment_on_checkout(
{
item => $item_1,
library => $library,
patron => $patron,
due_date => $five_days_ago,
expiration_date => $expected_expiration,
}
);
}
# We want to charge 2 days every 2 days, without grace
# With 5 days of overdue: (5 * 2) / 2
Koha::CirculationRules->set_rule(