Bug 8914: Blank search that returns invalid authorities fails under Plack

When doing a search with no terms for the default authority type under
Plack, you will get a segfault if it returns any records that do not
have any authority type. As far as I can tell, this cannot be reproduced
under CGI/Apache.

To test:
Confirm that you don't get an error if you click the Submit button in
the authorities sections in the staff client and OPAC without entering
a term or changing the authority type.

You may or may not be able to reproduce the problem prior to applying
the patch, but that is the only situation in which I managed to trigger
it.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This commit is contained in:
Jared Camins-Esakov 2012-10-12 22:49:07 -04:00 committed by Paul Poulain
parent b81bb697a4
commit ae977a9cfd
1 changed files with 2 additions and 2 deletions

View File

@ -359,9 +359,9 @@ sub SearchAuthorities {
}
}
my $thisauthtype = GetAuthType(GetAuthTypeCode($authid));
$thisauthtype |= GetAuthType($authtypecode) if $authtypecode;
$newline{authtype} = defined ($thisauthtype) ?
$thisauthtype->{'authtypetext'} :
(GetAuthType($authtypecode) ? $_->{'authtypetext'} : '');
$thisauthtype->{'authtypetext'} : '';
$newline{summary} = $summary;
$newline{even} = $counter % 2;
$newline{reported_tag} = $reported_tag;