gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 28586: (follow-up) updated_by should be set 

This patch makes the route set the 'updated_by' attribute as well, when
resolving a return claim through the API.

Tests are added for this behavior.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/return_claims.t
=> SUCCESS: Tests pass! updated_by is set correctly!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 343bf361e0)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Tomas Cohen Arazi 2021-06-17 16:02:35 -03:00 committed by Fridolin Somers
parent 513a471f1f
commit ab02ae9c43
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Koha/REST/V1/ReturnClaims.pm
View File

@ -171,6 +171,7 @@ sub resolve_claim {
resolution => $resolution,
resolved_by => $resolved_by,
resolved_on => \'NOW()',
updated_by => $resolved_by,
}
)->store;
$claim->discard_changes;

10
t/db_dependent/api/v1/return_claims.t
View File

@ -175,7 +175,7 @@ subtest 'update_notes() tests' => sub {
subtest 'resolve_claim() tests' => sub {
plan tests => 8;
plan tests => 9;
$schema->storage->txn_begin;
@ -204,7 +204,12 @@ subtest 'resolve_claim() tests' => sub {
my $claim_id = $claim->id;
$claim->created_by(undef)->store; # resolve the claim must work even if the created_by patron has been removed
$claim->set(
{
created_by => undef,
updated_by => undef,
}
)->store; # resolve the claim must work even if the created_by patron has been removed
# Resolve a claim
$t->put_ok(
@ -217,6 +222,7 @@ subtest 'resolve_claim() tests' => sub {
$claim->discard_changes;
is( $claim->resolution, "FOUNDINLIB" );
is( $claim->resolved_by, $librarian->id );
is( $claim->updated_by, $librarian->id );
ok( $claim->resolved_on );
# Make sure the claim doesn't exist on the DB anymore