gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 26518: (QA follow-up) Expect warnings, don't supress them 

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Nick Clemens 2020-11-23 12:09:47 +00:00 committed by Jonathan Druart
parent 9038cdd9a4
commit a8b89fe66a
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
t/db_dependent/Biblio.t
View File

@ -19,6 +19,7 @@ use Modern::Perl;
use Test::More tests => 15;
use Test::MockModule;
use Test::Warn;
use List::MoreUtils qw( uniq );
use MARC::Record;
@ -43,7 +44,7 @@ Koha::Caches->get_instance->clear_from_cache( "MarcSubfieldStructure-" );
my $builder = t::lib::TestBuilder->new;
subtest 'AddBiblio' => sub {
plan tests => 3;
plan tests => 4;
my $marcflavour = 'MARC21';
t::lib::Mocks::mock_preference( 'marcflavour', $marcflavour );
@ -56,12 +57,9 @@ subtest 'AddBiblio' => sub {
my $nb_biblios = Koha::Biblios->count;
my ( $biblionumber, $biblioitemnumber );
{
local *STDERR;
open STDERR, '>', '/dev/null';
( $biblionumber, $biblioitemnumber ) = C4::Biblio::AddBiblio( $record, '' );
close STDERR;
}
warnings_like { ( $biblionumber, $biblioitemnumber ) = C4::Biblio::AddBiblio( $record, '' ) }
[ qr/Data too long for column 'lccn'/, qr/Data too long for column 'lccn'/ ],
"expected warnings when adding too long LCCN";
is( $biblionumber, undef,
'AddBiblio returns undef for biblionumber if something went wrong' );
is( $biblioitemnumber, undef,