gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 18050: (QA follow-up) Adjust conditions and make use of message text 

- When we run into invalid data, we use Augustin's suggested solution
  and copy the data into a separate table, setting the budget_period_id to
  NULL.
- We amend the output using the new $message.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 3c8bef50a2)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Katrin Fischer 2020-10-05 06:17:34 +00:00 committed by Lucas Gass
parent 5fc0d24ca8
commit a88f367c63
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
installer/data/mysql/atomicupdate/bug_18050_aqbudget_constraint.perl
View File

@ -3,32 +3,34 @@ if( CheckVersion( $DBversion ) ) {
my $count_missing_budget = $dbh->selectrow_arrayref(q|
SELECT COUNT(*) FROM aqbudgets ab WHERE NOT EXISTS
(SELECT * FROM aqbudgetperiods abp WHERE abp.budget_period_id = ab.budget_period_id)
AND budget_period_id IS NOT NULL;
|);
my $message = "";
if($count_missing_budget->[0] > 0) {
$dbh->do(q{
$dbh->do(q|
CREATE TABLE _bug_18050_aqbudgets AS
SELECT * FROM aqbudgets ab WHERE NOT EXISTS
(SELECT * FROM aqbudgetperiods abp WHERE abp.budget_period_id = ab.budget_period_id)
});
|);
$dbh->do(q{
$dbh->do(q|
UPDATE aqbudgets ab SET budget_period_id = NULL
WHERE NOT EXISTS
(SELECT * FROM aqbudgetperiods abp WHERE abp.budget_period_id = ab.budget_period_id)
});
|);
$message = ". There are $count_missing_budget->[0] funds in your database that are not linked
to a valid budget. Setting invalid budget id (budget_period_id) to null. The table _bug_18050_aqbudgets
was created with original data. Please check that table and place valid ids in aqbudget table as soon as possible."
$message = "There are $count_missing_budget->[0] funds in your database that are not linked to a valid budget. Setting invalid budget id (budget_period_id) to null. The table _bug_18050_aqbudgets was created with original data. Please check that table and place valid ids in aqbudget table as soon as possible."
}
if ( !foreign_key_exists( 'aqbudgets', 'aqbudgetperiods_ibfk_1' ) && $count_missing_budget->[0] == 0 ) {
if ( !foreign_key_exists( 'aqbudgets', 'aqbudgetperiods_ibfk_1' ) ) {
$dbh->do(q|
ALTER TABLE aqbudgets ADD CONSTRAINT `aqbudgetperiods_ibfk_1` FOREIGN KEY (`budget_period_id`) REFERENCES `aqbudgetperiods` (`budget_period_id`) ON UPDATE CASCADE ON DELETE CASCADE
|);
NewVersion( $DBversion, 18050, "Add FK constraint on aqbudgets.budget_period_id");
NewVersion( $DBversion, 18050, "Add FK constraint on aqbudgets.budget_period_id$message");
} else {
NewVersion( $DBversion, 18050, "FK constraint on aqbudgets.budget already exists");
}