gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 39589: (QA follow-up) Revert unrelated star rating markup change 

The read-only star rating widget in search results was changed from
<span> to <a href="#"> elements, unrelated to this bug's fix. That
activated a pre-existing but previously dead click handler
($(".br-readonly a") in this same template) and turned every star icon
into a focusable, non-functional link, adding up to 5 dead tab stops
per search result. Restore the <span> markup used everywhere else this
read-only widget appears.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
This commit is contained in:
Martin Renvoize 2026-08-04 10:46:14 +01:00 committed by Pedro Amorim
parent 84831855d2
commit a8523740b0
No known key found for this signature in database
GPG Key ID: 06B75BA7F3894D55
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
View File

@ -404,11 +404,11 @@
<div class="br-widget br-readonly">
[% FOREACH i IN [ 1 2 3 4 5 ] %]
[% IF rating_avg_int == i %]
<a href="#" class="br-selected br-current"></a>
<span class="br-selected br-current"></span>
[% ELSIF rating_avg_int > i %]
<a href="#" class="br-selected"></a>
<span class="br-selected"></span>
[% ELSE %]
<a href="#"></a>
<span></span>
[% END %]
[% END %]
</div>