gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 30667: Holds reminder cronjob (holds_reminder.pl) never uses default letter template 

Bug 28514 changed the way holds_reminder.pl searches for templates, using a direct search for letters,
but should be using find_effective_template instead. Now, if a branch specific template does not exist,
it will skip that branch.

Test Plan:
1) Ensure you only have the default HOLD_REMINDER template
2) Become the koha user using koha-shell
3) Run misc/cronjobs/holds/holds_reminder.pl --days 7 -v
4) Note that the script skips every branch
5) Apply this patch
6) Run the command in step 3 again
7) Note the script doesn't skip over any branches

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Kyle Hall 2022-05-03 06:53:43 -04:00 committed by Fridolin Somers
parent 49fec1549b
commit a7e7939748
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
misc/cronjobs/holds/holds_reminder.pl
View File

@ -228,14 +228,14 @@ foreach my $branchcode (@branchcodes) { #BEGIN BRANCH LOOP
# Check that this branch has the letter code specified or skip this branch
# FIXME What if we don't want to default if the translated template does not exist?
my $template_exists = Koha::Notice::Templates->search(
my $template_exists = Koha::Notice::Templates->find_effective_template(
{
module => 'reserves',
code => $lettercode,
branchcode => $branchcode,
lang => 'default',
}
)->count;
);
unless ($template_exists) {
$verbose and print qq|Message '$lettercode' content not found for $branchcode\n|;
next;