gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 24003: Regression tests 

This patch adds regression tests for the different authentication
mechanisms Koha supports. It highlights the fact that Koha expects
userenv to be set on authentication.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit f1a3fad1fc)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Tomas Cohen Arazi 2020-06-05 09:15:19 -03:00 committed by Lucas Gass
parent 5b263c80dc
commit a2ef8f64c4
2 changed files with 43 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
t/db_dependent/api/v1/auth_authenticate_api_request.t
View File

@ -44,7 +44,7 @@ t::lib::Mocks::mock_preference( 'SessionStorage', 'tmp' );
subtest 'token-based tests' => sub {
if ( can_load( modules => { 'Net::OAuth2::AuthorizationServer' => undef } ) ) {
plan tests => 12;
plan tests => 14;
}
else {
plan skip_all => 'Net::OAuth2::AuthorizationServer not available';
@ -74,22 +74,30 @@ subtest 'token-based tests' => sub {
my $access_token = $t->tx->res->json->{access_token};
# With access token and permissions, it returns 200
#$patron->flags(2**4)->store;
my $stash;
my $interface;
my $userenv;
my $tx = $t->ua->build_tx(GET => '/api/v1/acquisitions/orders');
$tx->req->headers->authorization("Bearer $access_token");
$tx->req->headers->header( 'x-koha-embed' => 'fund' );
$t->app->hook(after_dispatch => sub { $stash = shift->stash });
$t->app->hook(after_dispatch => sub {
$stash = shift->stash;
$interface = C4::Context->interface;
$userenv = C4::Context->userenv;
});
# With access token and permissions, it returns 200
#$patron->flags(2**4)->store;
$t->request_ok($tx)->status_is(200);
my $user = $stash->{'koha.user'};
ok( defined $user, 'The \'koha.user\' object is defined in the stash') and
is( ref($user), 'Koha::Patron', 'Stashed koha.user object type is Koha::Patron') and
is( $user->borrowernumber, $patron->borrowernumber, 'The stashed user is the right one' );
is( $userenv->{number}, $patron->borrowernumber, 'userenv set correctly' );
is( $interface, 'api', "Interface correctly set to \'api\'" );
my $embed = $stash->{'koha.embed'};
ok( defined $embed, 'The embed hashref is generated and stashed' );
@ -100,7 +108,7 @@ subtest 'token-based tests' => sub {
subtest 'cookie-based tests' => sub {
plan tests => 6;
plan tests => 8;
$schema->storage->txn_begin;
@ -111,13 +119,23 @@ subtest 'cookie-based tests' => sub {
$tx->req->env( { REMOTE_ADDR => $remote_address } );
my $stash;
$t->app->hook(after_dispatch => sub { $stash = shift->stash });
my $interface;
my $userenv;
$t->app->hook(after_dispatch => sub {
$stash = shift->stash;
$interface = C4::Context->interface;
$userenv = C4::Context->userenv;
});
$t->request_ok($tx)->status_is(200);
my $user = $stash->{'koha.user'};
ok( defined $user, 'The \'koha.user\' object is defined in the stash') and
is( ref($user), 'Koha::Patron', 'Stashed koha.user object type is Koha::Patron') and
is( $user->borrowernumber, $borrowernumber, 'The stashed user is the right one' );
is( $userenv->{number}, $borrowernumber, 'userenv set correctly' );
is( $interface, 'api', "Interface correctly set to \'api\'" );
subtest 'logged-out tests' => sub {
plan tests => 3;

19
t/db_dependent/api/v1/auth_basic.t
View File

@ -30,7 +30,7 @@ my $t = Test::Mojo->new('Koha::REST::V1');
subtest 'success tests' => sub {
plan tests => 5;
plan tests => 10;
$schema->storage->txn_begin;
@ -43,9 +43,26 @@ subtest 'success tests' => sub {
$patron->set_password({ password => $password });
my $userid = $patron->userid;
my $stash;
my $interface;
my $userenv;
$t->app->hook(after_dispatch => sub {
$stash = shift->stash;
$interface = C4::Context->interface;
$userenv = C4::Context->userenv;
});
$t->get_ok("//$userid:$password@/api/v1/patrons")
->status_is( 200, 'Successful authentication and permissions check' );
my $user = $stash->{'koha.user'};
ok( defined $user, 'The \'koha.user\' object is defined in the stash') and
is( ref($user), 'Koha::Patron', 'Stashed koha.user object type is Koha::Patron') and
is( $user->borrowernumber, $patron->borrowernumber, 'The stashed user is the right one' );
is( $userenv->{number}, $patron->borrowernumber, 'userenv set correctly' );
is( $interface, 'api', "Interface correctly set to \'api\'" );
$patron->flags(undef)->store;
$t->get_ok("//$userid:$password@/api/v1/patrons")