gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 20581: (follow-up) Fix status_alias comparison 

status_alias will arrive in the Koha object as a string, so when we
special case it, we should also pass a string

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Andrew Isherwood 2019-02-06 14:17:01 +00:00 committed by Nick Clemens
parent cee652af6b
commit a2ced89ab4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Koha/Illrequest.pm
View File

@ -185,7 +185,7 @@ sub status_alias {
# https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c156
# We need a way of accepting implied undef, so we can nullify
# the status_alias column, when called from $self->status
my $val = $newval == -1 ? undef : $newval;
my $val = $newval eq "-1" ? undef : $newval;
my $newval = $self->SUPER::status_alias($newval);
if ($newval) {
return $newval;
@ -225,7 +225,7 @@ sub status {
# https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c156
# We need a way of passing implied undef to nullify status_alias
# so we pass -1, which is special cased in the overloaded setter
$self->status_alias(-1);
$self->status_alias("-1");
return $self->SUPER::status($newval);
}
return $self->SUPER::status;