gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 6679 : cataloguing/ now passing critic tests 

Declare variables outside of conditionals
Don't use prototypes http://www.modernperlbooks.com/mt/2009/08/the-problem-with-prototypes.html
Use ":encoding(UTF-8)" to get strict validation.
This commit is contained in:
Chris Cormack 2011-10-31 21:16:29 +13:00 committed by Paul Poulain
parent b9d743a928
commit a047dea5e4
5 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cataloguing/addbiblio.pl
View File

@ -159,7 +159,7 @@ sub MARCfindbreeding {
=cut
sub build_authorized_values_list ($$$$$$$) {
sub build_authorized_values_list {
my ( $tag, $subfield, $value, $dbh, $authorised_values_sth,$index_tag,$index_subfield ) = @_;
my @authorised_values;
@ -252,7 +252,7 @@ sub build_authorized_values_list ($$$$$$$) {
=cut
sub CreateKey(){
sub CreateKey {
return int(rand(1000000));
}
@ -263,7 +263,7 @@ sub CreateKey(){
=cut
sub GetMandatoryFieldZ3950($){
sub GetMandatoryFieldZ3950 {
my $frameworkcode = shift;
my @isbn = GetMarcFromKohaField('biblioitems.isbn',$frameworkcode);
my @title = GetMarcFromKohaField('biblio.title',$frameworkcode);
@ -536,7 +536,7 @@ sub format_indicator {
return $ind_value;
}
sub build_tabs ($$$$$) {
sub build_tabs {
my ( $template, $record, $dbh, $encoding,$input ) = @_;
# fill arrays

3
cataloguing/additem.pl
View File

@ -381,7 +381,8 @@ if ($op eq "additem") {
my ($tagfield,$tagsubfield) = &GetMarcFromKohaField("items.barcode",$frameworkcode);
# If there is a barcode and we can't find him new values, we can't add multiple copies
my $testbarcode = $barcodeobj->next_value($oldbarcode) if $barcodeobj;
my $testbarcode;
$testbarcode = $barcodeobj->next_value($oldbarcode) if $barcodeobj;
if ($oldbarcode && !$testbarcode) {
push @errors, "no_next_barcode";

2
cataloguing/merge.pl
View File

@ -250,7 +250,7 @@ Create a random value to set it into the input name
=cut
sub createKey(){
sub createKey {
return int(rand(1000000));
}

2
cataloguing/ysearch.pl
View File

@ -39,7 +39,7 @@ my $field = $input->param('field');
# Prevent from disclosing data
die() unless ($table eq "biblioitems");
binmode STDOUT, ":utf8";
binmode STDOUT, ":encoding(UTF-8)";
print $input->header( -type => 'text/plain', -charset => 'UTF-8' );
my ( $auth_status, $sessionID ) = check_cookie_auth( $input->cookie('CGISESSID'), { cataloguing => '*' } );

2
t/00-testcritic.t
View File

@ -16,7 +16,7 @@ my @all_koha_dirs = qw( acqui admin authorities basket C4 catalogue cataloguing
labels members misc offline_circ opac patroncards reports reserve reviews rotating_collections
serials sms suggestion t tags test tools virtualshelves);
my @dirs = qw( acqui admin authorities basket catalogue circ debian errors offline_circ reserve
my @dirs = qw( acqui admin authorities basket catalogue cataloguing circ debian errors offline_circ reserve
reviews rotating_collections serials sms virtualshelves );
if ( not $ENV{TEST_QA} ) {