gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 37526: (QA follow-up) Tidy 

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Nick Clemens 2024-09-26 19:53:28 +00:00 committed by Katrin Fischer
parent a1f0fc04d1
commit 9fad5e0321
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
1 changed files with 63 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

94
t/db_dependent/Koha/BackgroundJob/ErmSushiHarvester.t
View File

@ -232,31 +232,48 @@ subtest 'is_redirect() tests' => sub {
$schema->storage->txn_begin;
my $ua = Test::MockModule->new('LWP::UserAgent');
$ua->mock('simple_request', sub {
$ua->mock(
'simple_request',
sub {
return mock_HTTP_redirect();
});
$ua->mock('get', sub {
return mock_sushi_response({'error'=>'invalid_api_key'});
});
}
);
$ua->mock(
'get',
sub {
return mock_sushi_response( { 'error' => 'invalid_api_key' } );
}
);
my $usage_data_provider = $builder->build_object(
{ class => 'Koha::ERM::EUsage::UsageDataProviders', value => { name => 'TestProvider' } } );
my $job_args = {
ud_provider_id => $usage_data_provider->erm_usage_data_provider_id,
report_type => 'TR_J1',
begin_date => '2023-08-01',
end_date => '2023-09-30',
ud_provider_name => $usage_data_provider->name,
};
ud_provider_id => $usage_data_provider->erm_usage_data_provider_id,
report_type => 'TR_J1',
begin_date => '2023-08-01',
end_date => '2023-09-30',
ud_provider_name => $usage_data_provider->name,
};
my $job_id = Koha::BackgroundJob::ErmSushiHarvester->new->enqueue($job_args);
my $job = Koha::BackgroundJobs->find($job_id)->_derived_class;
$job->process( $job_args );
my $job = Koha::BackgroundJobs->find($job_id)->_derived_class;
$job->process($job_args);
is( $job->{messages}[0]->{message}, decode_json($sushi_response_errors->{invalid_api_key})->{Severity} . ' - ' . decode_json($sushi_response_errors->{invalid_api_key})->{Message},'SUSHI error invalid_date_arguments is stored on job messages correctly' );
is( $job->{messages}[0]->{type},'error','SUSHI error invalid_date_arguments is stored on job messages correctly' );
is( $job->{messages}[0]->{code},decode_json($sushi_response_errors->{invalid_api_key})->{Code},'SUSHI error invalid_date_arguments is stored on job messages correctly' );
is(
$job->{messages}[0]->{message},
decode_json( $sushi_response_errors->{invalid_api_key} )->{Severity} . ' - '
. decode_json( $sushi_response_errors->{invalid_api_key} )->{Message},
'SUSHI error invalid_date_arguments is stored on job messages correctly'
);
is(
$job->{messages}[0]->{type}, 'error',
'SUSHI error invalid_date_arguments is stored on job messages correctly'
);
is(
$job->{messages}[0]->{code}, decode_json( $sushi_response_errors->{invalid_api_key} )->{Code},
'SUSHI error invalid_date_arguments is stored on job messages correctly'
);
$schema->storage->txn_rollback;
};
@ -296,19 +313,34 @@ sub mock_sushi_response {
sub mock_HTTP_redirect {
my $response = Test::MockObject->new();
$response->mock('code', sub {
return 301;
});
$response->mock('is_error', sub {
return 0;
});
$response->mock('is_redirect', sub {
return 1;
});
$response->mock('header', sub {
return 'www.whatever.com';
});
$response->mock('decoded_content', sub {
return 'Moved permanently';
});
$response->mock(
'code',
sub {
return 301;
}
);
$response->mock(
'is_error',
sub {
return 0;
}
);
$response->mock(
'is_redirect',
sub {
return 1;
}
);
$response->mock(
'header',
sub {
return 'www.whatever.com';
}
);
$response->mock(
'decoded_content',
sub {
return 'Moved permanently';
}
);
}