gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 27068: Fix errors in _checkHoldPolicy 

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Kyle M Hall 2020-12-03 06:34:33 -05:00 committed by Jonathan Druart
parent e82091f40a
commit 9f71452b93
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
C4/HoldsQueue.pm
View File

@ -383,12 +383,12 @@ sub _checkHoldPolicy {
my $hold_fulfillment_policy = $item->{hold_fulfillment_policy};
return 0 if $hold_fulfillment_policy eq 'holdgroup' && !$library->validate_hold_sibling({branchcode => $request->{branchcode}});
return 0 if $hold_fulfillment_policy eq 'homebranch' && $request->{branchcode} ne $item->$hold_fulfillment_policy;
return 0 if $hold_fulfillment_policy eq 'holdingbranch' && $request->{branchcode} ne $item->$hold_fulfillment_policy;
return 0 if $hold_fulfillment_policy eq 'homebranch' && $request->{branchcode} ne $item->{$hold_fulfillment_policy};
return 0 if $hold_fulfillment_policy eq 'holdingbranch' && $request->{branchcode} ne $item->{$hold_fulfillment_policy};
my $patronLibrary = Koha::Libraries->find($request->{borrowerbranch});
return 0 if $hold_fulfillment_policy eq 'patrongroup' && !patronLibrary->validate_hold_sibling({branchcode => $request->{branchcode}});
return 0 if $hold_fulfillment_policy eq 'patrongroup' && !$patronLibrary->validate_hold_sibling({branchcode => $request->{branchcode}});
return 1;

3
Koha/Library.pm
View File

@ -240,6 +240,9 @@ Return if given library is a valid hold group member
sub validate_hold_sibling {
my ( $self, $params ) = @_;
return 1 if $params->{branchcode} eq $self->id;
my @hold_libraries = $self->get_hold_libraries;
foreach (@hold_libraries) {